• 
      

    Add Dark Mode for the Admin UI.

    Review Request #14166 — Created Sept. 12, 2024 and submitted

    Information

    Review Board
    release-7.x

    Reviewers

    Review Board 7.1 will ship with Dark Mode enabled all throughout the
    product. We introduced it as a beta, opt-in feature in 7.0, but we
    didn't have it universally, as we didn't have time to convert the Admin
    UI or some of the components in Djblets. Since then, we've made progress
    on pretty much every component the Admin UI depends on.

    We now support Dark Mode all throughout. This includes all the Admin
    settings pages, dashboard widgets, security checks, and more. Colors
    were converted to Ink color palettes, buttons to Ink buttons, and
    various styles fixed.

    An upcoming change will enable Dark Mode for all users based on system
    settings.

    As a note, the support banner in the Admin Dashboard is bright, but there
    are plans to make further changes specifically to this area in an
    upcoming change, so it will remain as alert styling for now.

    Tested all pages in the Admin UI in dark mode and in light mode, checking
    for any visual issues.

    Screenshots on the review request are included just for notable pages.
    Most use standard dark mode styling and color palettes and aren't notable.

    Summary ID
    Add Dark Mode for the Admin UI.
    Review Board 7.1 will ship with Dark Mode enabled all throughout the product. We introduced it as a beta, opt-in feature in 7.0, but we didn't have it universally, as we didn't have time to convert the Admin UI or some of the components in Djblets. Since then, we've made progress on pretty much every component the Admin UI depends on. We now support Dark Mode all throughout. This includes all the Admin settings pages, dashboard widgets, security checks, and more. Colors were converted to Ink color palettes, buttons to Ink buttons, and various styles fixed. An upcoming change will enable Dark Mode for all users based on system settings.
    f43757d1354f1b034750189652a0aa3c9dba1979

    Description From Last Updated

    Can we indent the second line to line up the class names?

    daviddavid
    david
    1. 
        
    2. reviewboard/scmtools/admin.py (Diff revision 1)
       
       
       
      Show all issues

      Can we indent the second line to line up the class names?

      1. There's no newline in this, so it'd end up as class="rb-c-admin-change-list__item-action ink-c-button {0}, which I don't love. I can I suppose re-build the class list.

    3. 
        
    chipx86
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-7.x (0834248)