Update the API token policy editor from $.modalBox to Ink.DialogView.

Review Request #14162 — Created Sept. 12, 2024 and updated

Information

Review Board
master

Reviewers

This change ports the API token policy editor pop-up from our old
modalBox function to the new DialogView.

  • Ran js-tests.
  • Verified that the functionality and appearance of the editor dialog worked as
    expected.
Summary ID
Update the API token policy editor from $.modalBox to Ink.DialogView.
This change ports the API token policy editor pop-up from our old `modalBox` function to the new `DialogView`. Testing Done: - Ran js-tests. - Verified that the functionality and appearance of the editor dialog worked as expected.
69f61e4892071c93d7dcc51c0800b8544d9f50fe
Description From Last Updated

Thoughts on using this format instead? super.initialize(_.defaults(options, { size: DialogSize.LARGE, })); I feel like I've seen us pass parent options …

maubinmaubin

These aren't in sort order.

chipx86chipx86

These aren't in sort order (craft and paint should be last).

chipx86chipx86

This should be localized.

chipx86chipx86

We should drop the let or the const.

chipx86chipx86
There are no open issues
maubin
  1. 
      
  2. Show all issues

    Thoughts on using this format instead?

    super.initialize(_.defaults(options, {
        size: DialogSize.LARGE,
    }));
    

    I feel like I've seen us pass parent options like that elsewhere in the codebase.

  3. 
      
david
maubin
  1. Ship It!
  2. 
      
chipx86
  1. 
      
  2. Show all issues

    These aren't in sort order.

  3. Show all issues

    These aren't in sort order (craft and paint should be last).

  4. Show all issues

    This should be localized.

  5. Show all issues

    We should drop the let or the const.

  6. 
      
david
Review request changed
Commits:
Summary ID
Update the API token policy editor from $.modalBox to Ink.DialogView.
This change ports the API token policy editor pop-up from our old `modalBox` function to the new `DialogView`. Testing Done: - Ran js-tests. - Verified that the functionality and appearance of the editor dialog worked as expected.
942b462c41ffa2f8a2cc3d7b2439c486556ccd0c
Update the API token policy editor from $.modalBox to Ink.DialogView.
This change ports the API token policy editor pop-up from our old `modalBox` function to the new `DialogView`. Testing Done: - Ran js-tests. - Verified that the functionality and appearance of the editor dialog worked as expected.
69f61e4892071c93d7dcc51c0800b8544d9f50fe
Diff:

Revision 3 (+338 -174)

Show changes

reviewboard/static/rb/css/pages/my-account.less
reviewboard/static/rb/js/accountPrefsPage/views/apiTokensView.ts

Checks run (2 succeeded)

flake8 passed.
JSHint passed.
chipx86
  1. Ship It!
  2. 
      
Loading...