Summary

Update the API token policy editor from $.modalBox to Ink.DialogView.

Review Request #14162 — Created Sept. 12, 2024 and submitted May 23, 2025, 11:02 a.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change ports the API token policy editor pop-up from our old

modalBox function to the new DialogView.

Testing Done


Ran js-tests.
Verified that the functionality and appearance of the editor dialog worked as

  expected.

Commits

Summary	ID
Update the API token policy editor from $.modalBox to Ink.DialogView. This change ports the API token policy editor pop-up from our old `modalBox` function to the new `DialogView`. Testing Done: - Ran js-tests. - Verified that the functionality and appearance of the editor dialog worked as expected.	69f61e4892071c93d7dcc51c0800b8544d9f50fe

Issues

Description	From	Last Updated
Thoughts on using this format instead? super.initialize(_.defaults(options, { size: DialogSize.LARGE, })); I feel like I've seen us pass parent options …	maubin	Sept. 13, 2024, 9:01 a.m.
These aren't in sort order.	chipx86	Jan. 17, 2025, 7:39 a.m.
These aren't in sort order (craft and paint should be last).	chipx86	Jan. 17, 2025, 7:39 a.m.
This should be localized.	chipx86	Jan. 17, 2025, 7:41 a.m.
We should drop the let or the const.	chipx86	Jan. 17, 2025, 7:41 a.m.

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/accountPrefsPage/views/apiTokensView.ts (Diff revision 1)

The issue has been resolved. Show all issues

Thoughts on using this format instead?
super.initialize(_.defaults(options, {
    size: DialogSize.LARGE,
}));

I feel like I've seen us pass parent options like that elsewhere in the codebase.

Commits:

	Summary	ID
	Update the API token policy editor from $.modalBox to Ink.DialogView. This change ports the API token policy editor pop-up from our old `modalBox` function to the new `DialogView`. Testing Done: - Ran js-tests. - Verified that the functionality and appearance of the editor dialog worked as expected.	5cf92490785a31da4b6c6763246ad42540cedceb
	Update the API token policy editor from $.modalBox to Ink.DialogView. This change ports the API token policy editor pop-up from our old `modalBox` function to the new `DialogView`. Testing Done: - Ran js-tests. - Verified that the functionality and appearance of the editor dialog worked as expected.	942b462c41ffa2f8a2cc3d7b2439c486556ccd0c

Diff:

Revision 2 (+338 -170)

Show changes

	reviewboard/static/rb/css/pages/my-account.less
	reviewboard/static/rb/js/accountPrefsPage/views/apiTokensView.ts

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

reviewboard/static/rb/js/accountPrefsPage/views/apiTokensView.ts (Diff revision 2)

The issue has been resolved. Show all issues

These aren't in sort order.

reviewboard/static/rb/js/accountPrefsPage/views/apiTokensView.ts (Diff revision 2)

The issue has been resolved. Show all issues

These aren't in sort order (craft and paint should be last).

reviewboard/static/rb/js/accountPrefsPage/views/apiTokensView.ts (Diff revision 2)
The issue has been resolved. Show all issues
```
This should be localized.
```

reviewboard/static/rb/js/accountPrefsPage/views/apiTokensView.ts (Diff revision 2)

The issue has been resolved. Show all issues

We should drop the let or the const.

Commits:

	Summary	ID
	Update the API token policy editor from $.modalBox to Ink.DialogView. This change ports the API token policy editor pop-up from our old `modalBox` function to the new `DialogView`. Testing Done: - Ran js-tests. - Verified that the functionality and appearance of the editor dialog worked as expected.	942b462c41ffa2f8a2cc3d7b2439c486556ccd0c
	Update the API token policy editor from $.modalBox to Ink.DialogView. This change ports the API token policy editor pop-up from our old `modalBox` function to the new `DialogView`. Testing Done: - Ran js-tests. - Verified that the functionality and appearance of the editor dialog worked as expected.	69f61e4892071c93d7dcc51c0800b8544d9f50fe

Diff:

Revision 3 (+338 -174)

Show changes

	reviewboard/static/rb/css/pages/my-account.less
	reviewboard/static/rb/js/accountPrefsPage/views/apiTokensView.ts

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (d6dd528)