Update the API token policy editor from $.modalBox to Ink.DialogView.
Review Request #14162 — Created Sept. 12, 2024 and updated
This change ports the API token policy editor pop-up from our old
modalBox
function to the newDialogView
.
- Ran js-tests.
- Verified that the functionality and appearance of the editor dialog worked as
expected.
Summary | ID |
---|---|
69f61e4892071c93d7dcc51c0800b8544d9f50fe |
Description | From | Last Updated | ||
---|---|---|---|---|
Thoughts on using this format instead? super.initialize(_.defaults(options, { size: DialogSize.LARGE, })); I feel like I've seen us pass parent options … |
![]() |
|||
These aren't in sort order. |
|
|||
These aren't in sort order (craft and paint should be last). |
|
|||
This should be localized. |
|
|||
We should drop the let or the const. |
|
|||
There are no open issues |
- Commits:
-
Summary ID 5cf92490785a31da4b6c6763246ad42540cedceb 942b462c41ffa2f8a2cc3d7b2439c486556ccd0c
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.