Convert RB.UploadAttachmentView to TypeScript/spina/Ink.

Review Request #14161 — Created Sept. 12, 2024 and updated — Latest diff uploaded

Information

Review Board
master

Reviewers

This change ports the UploadAttachmentView to TypeScript, and changes it
so it now inherits from the new Ink.DialogView.

  • Ran js-tests.
  • Uploaded new file attachments.
  • Uploaded new versions of existing file attachments.

Diff Revision 1

This is not the most recent revision of the diff. The latest diff is revision 2. See what's changed.

orig
1
2

Commits

First Last Summary ID Author
Convert RB.UploadAttachmentView to TypeScript/spina/Ink.
This change ports the UploadAttachmentView to TypeScript, and changes it so it now inherits from the new `Ink.DialogView`. Testing Done: - Ran js-tests. - Uploaded new file attachments. - Uploaded new versions of existing file attachments.
af3ba609f3806923e93329498b4120946eac6951 David Trowbridge
reviewboard/staticbundles.py
reviewboard/static/rb/js/common/resources/models/baseResourceModel.ts
reviewboard/static/rb/js/reviews/index.ts
reviewboard/static/rb/js/reviews/views/fileAttachmentThumbnailView.ts
reviewboard/static/rb/js/reviews/views/reviewRequestActions.ts
reviewboard/static/rb/js/reviews/views/uploadAttachmentView.ts
reviewboard/static/rb/js/reviews/views/tests/index.ts
reviewboard/static/rb/js/views/tests/uploadAttachmentViewTests.es6.js
reviewboard/static/rb/js/views/uploadAttachmentView.es6.js
Loading...