Summary

Convert RB.UploadAttachmentView to TypeScript/spina/Ink.

Review Request #14161 — Created Sept. 12, 2024 and updated Sept. 16, 2024, 8:21 a.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change ports the UploadAttachmentView to TypeScript, and changes it
so it now inherits from the new Ink.DialogView.

Testing Done


Ran js-tests.
Uploaded new file attachments.
Uploaded new versions of existing file attachments.

Commits

Summary	ID
Convert RB.UploadAttachmentView to TypeScript/spina/Ink. This change ports the UploadAttachmentView to TypeScript, and changes it so it now inherits from the new `Ink.DialogView`. Testing Done: - Ran js-tests. - Uploaded new file attachments. - Uploaded new versions of existing file attachments.	1a0b362020810215208a9c63eb89016dfc9cda49

Issues

Description	From	Last Updated
If we're doing an Ink release alongside 7.0.3, it would be nice to put this into 7.0.3. This'll fix some …	maubin	Sept. 13, 2024, 8:59 a.m.
I think you meant to say "uploading" instead of "updating"? And maybe it's more apt to say "a file attachment" …	maubin	Sept. 13, 2024, 8:58 a.m.
Same here.	maubin	Sept. 13, 2024, 8:58 a.m.
Typo: "eceieved" -> "received"	maubin	Sept. 13, 2024, 8:59 a.m.

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues

If we're doing an Ink release alongside 7.0.3, it would be nice to put this into 7.0.3. This'll fix some ugliness on mobile where the upload attachment dialog is too big for the screen and gets cut off.

david Sept. 13, 2024, 9 a.m.

Hmmm, I'm not sure. We'll have to see what Christian wants to do there.

reviewboard/static/rb/js/reviews/views/uploadAttachmentView.ts (Diff revision 1)

The issue has been resolved. Show all issues

I think you meant to say "uploading" instead of "updating"? And maybe it's more apt to say "a file attachment" instead of "file attachments" since we can really only upload one attachment at a time from this dialog.

reviewboard/static/rb/js/reviews/views/uploadAttachmentView.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Same here.
```
reviewboard/static/rb/js/reviews/views/uploadAttachmentView.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Typo: "eceieved" -> "received"
```

Commits:

	Summary	ID
	Convert RB.UploadAttachmentView to TypeScript/spina/Ink. This change ports the UploadAttachmentView to TypeScript, and changes it so it now inherits from the new `Ink.DialogView`. Testing Done: - Ran js-tests. - Uploaded new file attachments. - Uploaded new versions of existing file attachments.	af3ba609f3806923e93329498b4120946eac6951
	Convert RB.UploadAttachmentView to TypeScript/spina/Ink. This change ports the UploadAttachmentView to TypeScript, and changes it so it now inherits from the new `Ink.DialogView`. Testing Done: - Ran js-tests. - Uploaded new file attachments. - Uploaded new versions of existing file attachments.	1a0b362020810215208a9c63eb89016dfc9cda49

Diff:

Revision 2 (+668 -460)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/common/resources/models/baseResourceModel.ts
	reviewboard/static/rb/js/reviews/index.ts
	reviewboard/static/rb/js/reviews/views/fileAttachmentThumbnailView.ts
	reviewboard/static/rb/js/reviews/views/reviewRequestActions.ts
	reviewboard/static/rb/js/reviews/views/uploadAttachmentView.ts
	reviewboard/static/rb/js/reviews/views/tests/index.ts
	reviewboard/static/rb/js/views/tests/uploadAttachmentViewTests.es6.js
	1 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```