• 
      

    Fix the display of diff comments of a review on mobile.

    Review Request #14159 — Created Sept. 11, 2024 and submitted

    Information

    Review Board
    release-7.x

    Reviewers

    For diff comments that were on new or deleted files, the heading for the file
    would spill outside of the review box. This is fixed by adding a
    display: grid to the diff table and to the filename row in the table for
    diffs that appear in review comments. This problem didn't appear for diff
    comments on existing files because we were already specifically giving
    them a grid display.

    • Looked at diff comments on new files in mobile and desktop.
    • Looked at diff comments on existing files in mobile and desktop.
    • Looked at the diff viewer in mobile and desktop, made sure it was the
      same as before.
    Summary ID
    Fix the display of diff comments of a review on mobile.
    For diff comments that were on new or deleted files, the heading for the file would spill outside of the review box. This is fixed by adding a `display: grid` to the diff table and to the filename row in the table for diffs that appear in review comments. This problem didn't appear for diff comments on existing files because we were already specifically giving them a grid display.
    58821a9f216ec0b324c5041fd5e32f7688709847

    chipx86
    1. Ship It!
    2. 
        
    david
    1. Ship It!
    2. 
        
    maubin
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-7.x (2986d9a)