Summary

Remove long-deprecated callbacks style resource invocations.

Review Request #14158 — Created Sept. 11, 2024 and updated 1 month, 3 weeks ago — Latest diff uploaded 1 month, 4 weeks ago

Information

Owner

david*

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description*

In Review Board 5, we added promises for our asynchronous operations in
our resource classes. We did this with fallbacks to handle old-style
calls that passed in callback methods. This change converts those
fallbacks to be errors instead.

Testing Done

Ran js-tests.

Changes between revision 2 and 3

orig

Commits

	Summary	ID	Author
	Remove long-deprecated callbacks style resource invocations. In Review Board 5, we added promises for our asynchronous operations in our resource classes. We did this with fallbacks to handle old-style calls that passed in callback methods. This change converts those fallbacks to be errors instead. Testing Done: Ran js-tests.	c2192b0a25ca7dbda6b00be338161d53dba203d9	David Trowbridge
	Remove long-deprecated callbacks style resource invocations. In Review Board 5, we added promises for our asynchronous operations in our resource classes. We did this with fallbacks to handle old-style calls that passed in callback methods. This change converts those fallbacks to be errors instead. Testing Done: Ran js-tests.	90aa0bd08ec450a53f427c3be03e5b8632de0a7d	David Trowbridge

Files

reviewboard/static/rb/js/common/resources/collections/resourceCollection.ts

reviewboard/static/rb/js/common/resources/collections/resourceCollection.ts