Remove long-deprecated callbacks style resource invocations.
Review Request #14158 — Created Sept. 11, 2024 and updated — Latest diff uploaded
In Review Board 5, we added promises for our asynchronous operations in
our resource classes. We did this with fallbacks to handle old-style
calls that passed in callback methods. This change converts those
fallbacks to be errors instead.
Ran js-tests.
Diff Revision 2
This is not the most recent revision of the diff. The latest diff is revision 3. See what's changed.
orig
1
2
3
Commits
Files
| reviewboard/static/rb/js/common/collections/baseCollection.ts |
|---|
| reviewboard/static/rb/js/common/resources/collections/repositoryCommitsCollection.ts |
|---|
| reviewboard/static/rb/js/common/resources/collections/resourceCollection.ts |
|---|
| reviewboard/static/rb/js/common/resources/collections/tests/resourceCollectionTests.ts |
|---|
| reviewboard/static/rb/js/common/resources/models/baseResourceModel.ts |
|---|
| reviewboard/static/rb/js/common/resources/models/draftResourceChildModelMixin.ts |
|---|
| reviewboard/static/rb/js/common/resources/models/draftResourceModelMixin.ts |
|---|
| reviewboard/static/rb/js/common/resources/models/draftReviewModel.ts |
|---|
| reviewboard/static/rb/js/common/resources/models/draftReviewRequestModel.ts |
|---|
| reviewboard/static/rb/js/common/resources/models/reviewGroupModel.ts |
|---|
| reviewboard/static/rb/js/common/resources/models/reviewReplyModel.ts |
|---|
| reviewboard/static/rb/js/common/resources/models/tests/baseResourceModelTests.ts |
|---|
| reviewboard/static/rb/js/common/resources/models/tests/draftReviewModelTests.ts |
|---|
| reviewboard/static/rb/js/common/resources/models/tests/draftReviewRequestModelTests.ts |
|---|
| reviewboard/static/rb/js/common/resources/models/tests/reviewGroupModelTests.ts |
|---|
| reviewboard/static/rb/js/common/resources/models/tests/reviewReplyModelTests.ts |
|---|
| reviewboard/static/rb/js/common/resources/models/tests/reviewRequestModelTests.ts |
|---|
| reviewboard/static/rb/js/reviews/models/commentEditorModel.ts |
|---|
| reviewboard/static/rb/js/reviews/models/tests/commentEditorModelTests.ts |
|---|