Remove long-deprecated callbacks style resource invocations.

Review Request #14158 — Created Sept. 11, 2024 and updated

Information

Review Board
master

Reviewers

In Review Board 5, we added promises for our asynchronous operations in
our resource classes. We did this with fallbacks to handle old-style
calls that passed in callback methods. This change converts those
fallbacks to be errors instead.

Ran js-tests.

Summary ID
Remove long-deprecated callbacks style resource invocations.
In Review Board 5, we added promises for our asynchronous operations in our resource classes. We did this with fallbacks to handle old-style calls that passed in callback methods. This change converts those fallbacks to be errors instead. Testing Done: Ran js-tests.
90aa0bd08ec450a53f427c3be03e5b8632de0a7d
Description From Last Updated

Indentation issue here.

chipx86chipx86

Copy paste-o: "fetchNext" -> "fetchAll"

maubinmaubin

These should order newest to oldest. This applies to other instances.

chipx86chipx86

Copy paste-o: "DraftReview" -> "DraftReviewRequest"

maubinmaubin

Ordering needs to be fixed here too.

chipx86chipx86

And here.

chipx86chipx86
There are no open issues
maubin
  1. 
      
  2. Show all issues

    Copy paste-o: "fetchNext" -> "fetchAll"

  3. Show all issues

    Copy paste-o: "DraftReview" -> "DraftReviewRequest"

  4. 
      
chipx86
  1. 
      
  2. Show all issues

    Indentation issue here.

  3. reviewboard/static/rb/js/common/resources/models/baseResourceModel.ts (Diff revision 1)
     
     
     
     
     
     
     
     
     
    Show all issues

    These should order newest to oldest. This applies to other instances.

  4. 
      
david
chipx86
  1. 
      
  2. Show all issues

    Ordering needs to be fixed here too.

  3. Show all issues

    And here.

  4. 
      
david
Review request changed
Commits:
Summary ID
Remove long-deprecated callbacks style resource invocations.
In Review Board 5, we added promises for our asynchronous operations in our resource classes. We did this with fallbacks to handle old-style calls that passed in callback methods. This change converts those fallbacks to be errors instead. Testing Done: Ran js-tests.
c2192b0a25ca7dbda6b00be338161d53dba203d9
Remove long-deprecated callbacks style resource invocations.
In Review Board 5, we added promises for our asynchronous operations in our resource classes. We did this with fallbacks to handle old-style calls that passed in callback methods. This change converts those fallbacks to be errors instead. Testing Done: Ran js-tests.
90aa0bd08ec450a53f427c3be03e5b8632de0a7d
Diff:

Revision 3 (+540 -1858)

Show changes

reviewboard/static/rb/js/common/collections/baseCollection.ts
reviewboard/static/rb/js/common/resources/collections/repositoryCommitsCollection.ts
reviewboard/static/rb/js/common/resources/collections/resourceCollection.ts
reviewboard/static/rb/js/common/resources/collections/tests/resourceCollectionTests.ts
reviewboard/static/rb/js/common/resources/models/baseResourceModel.ts
reviewboard/static/rb/js/common/resources/models/draftResourceChildModelMixin.ts
reviewboard/static/rb/js/common/resources/models/draftResourceModelMixin.ts
reviewboard/static/rb/js/common/resources/models/draftReviewModel.ts
11 more

Checks run (2 succeeded)

flake8 passed.
JSHint passed.
chipx86
  1. Ship It!
  2. 
      
Loading...