Summary

Remove long-deprecated callbacks style resource invocations.

Review Request #14158 — Created Sept. 11, 2024 and submitted June 10, 2025, 9:10 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

In Review Board 5, we added promises for our asynchronous operations in
our resource classes. We did this with fallbacks to handle old-style
calls that passed in callback methods. This change converts those
fallbacks to be errors instead.

Testing Done

Ran js-tests.

Commits

Summary	ID
Remove long-deprecated callbacks style resource invocations. In Review Board 5, we added promises for our asynchronous operations in our resource classes. We did this with fallbacks to handle old-style calls that passed in callback methods. This change converts those fallbacks to be errors instead. Testing Done: Ran js-tests.	90aa0bd08ec450a53f427c3be03e5b8632de0a7d

Issues

Description	From	Last Updated
Indentation issue here.	chipx86	Jan. 16, 2025, 11:04 p.m.
Copy paste-o: "fetchNext" -> "fetchAll"	maubin	Sept. 13, 2024, 3:57 p.m.
These should order newest to oldest. This applies to other instances.	chipx86	Jan. 16, 2025, 11:09 p.m.
Copy paste-o: "DraftReview" -> "DraftReviewRequest"	maubin	Sept. 13, 2024, 3:57 p.m.
Ordering needs to be fixed here too.	chipx86	Feb. 4, 2025, 4:14 p.m.
And here.	chipx86	Feb. 4, 2025, 4:14 p.m.

flake8 passed.

JSHint passed.

Ship it!

reviewboard/static/rb/js/common/resources/collections/resourceCollection.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Copy paste-o: "fetchNext" -> "fetchAll"
```
reviewboard/static/rb/js/common/resources/models/draftReviewRequestModel.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Copy paste-o: "DraftReview" -> "DraftReviewRequest"
```

reviewboard/static/rb/js/common/resources/collections/resourceCollection.ts (Diff revision 1)

The issue has been resolved. Show all issues

Indentation issue here.

reviewboard/static/rb/js/common/resources/models/baseResourceModel.ts (Diff revision 1)

The issue has been resolved. Show all issues

These should order newest to oldest. This applies to other instances.

Change Summary:

Make requested changes.

Commits:

	Summary	ID
	Remove long-deprecated callbacks style resource invocations. In Review Board 5, we added promises for our asynchronous operations in our resource classes. We did this with fallbacks to handle old-style calls that passed in callback methods. This change converts those fallbacks to be errors instead. Testing Done: Ran js-tests.	85216634555a41fc569e6725492b6605ca047d03
	Remove long-deprecated callbacks style resource invocations. In Review Board 5, we added promises for our asynchronous operations in our resource classes. We did this with fallbacks to handle old-style calls that passed in callback methods. This change converts those fallbacks to be errors instead. Testing Done: Ran js-tests.	c2192b0a25ca7dbda6b00be338161d53dba203d9

Diff:

Revision 2 (+540 -1858)

Show changes

	reviewboard/static/rb/js/common/collections/baseCollection.ts
	reviewboard/static/rb/js/common/resources/collections/repositoryCommitsCollection.ts
	reviewboard/static/rb/js/common/resources/collections/resourceCollection.ts
	reviewboard/static/rb/js/common/resources/collections/tests/resourceCollectionTests.ts
	reviewboard/static/rb/js/common/resources/models/baseResourceModel.ts
	reviewboard/static/rb/js/common/resources/models/draftResourceChildModelMixin.ts
	reviewboard/static/rb/js/common/resources/models/draftResourceModelMixin.ts
	reviewboard/static/rb/js/common/resources/models/draftReviewModel.ts
	11 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/common/resources/collections/resourceCollection.ts (Diff revision 2)

The issue has been resolved. Show all issues

Ordering needs to be fixed here too.

reviewboard/static/rb/js/common/resources/collections/resourceCollection.ts (Diff revision 2)

The issue has been resolved. Show all issues

And here.

Commits:

	Summary	ID
	Remove long-deprecated callbacks style resource invocations. In Review Board 5, we added promises for our asynchronous operations in our resource classes. We did this with fallbacks to handle old-style calls that passed in callback methods. This change converts those fallbacks to be errors instead. Testing Done: Ran js-tests.	c2192b0a25ca7dbda6b00be338161d53dba203d9
	Remove long-deprecated callbacks style resource invocations. In Review Board 5, we added promises for our asynchronous operations in our resource classes. We did this with fallbacks to handle old-style calls that passed in callback methods. This change converts those fallbacks to be errors instead. Testing Done: Ran js-tests.	90aa0bd08ec450a53f427c3be03e5b8632de0a7d

Diff:

Revision 3 (+540 -1858)

Show changes

	reviewboard/static/rb/js/common/collections/baseCollection.ts
	reviewboard/static/rb/js/common/resources/collections/repositoryCommitsCollection.ts
	reviewboard/static/rb/js/common/resources/collections/resourceCollection.ts
	reviewboard/static/rb/js/common/resources/collections/tests/resourceCollectionTests.ts
	reviewboard/static/rb/js/common/resources/models/baseResourceModel.ts
	reviewboard/static/rb/js/common/resources/models/draftResourceChildModelMixin.ts
	reviewboard/static/rb/js/common/resources/models/draftResourceModelMixin.ts
	reviewboard/static/rb/js/common/resources/models/draftReviewModel.ts
	11 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (b76c494)