Remove long-deprecated callbacks style resource invocations.
Review Request #14158 — Created Sept. 11, 2024 and updated
In Review Board 5, we added promises for our asynchronous operations in
our resource classes. We did this with fallbacks to handle old-style
calls that passed in callback methods. This change converts those
fallbacks to be errors instead.
Ran js-tests.
Summary | ID |
---|---|
90aa0bd08ec450a53f427c3be03e5b8632de0a7d |
Description | From | Last Updated | ||
---|---|---|---|---|
Indentation issue here. |
|
|||
Copy paste-o: "fetchNext" -> "fetchAll" |
![]() |
|||
These should order newest to oldest. This applies to other instances. |
|
|||
Copy paste-o: "DraftReview" -> "DraftReviewRequest" |
![]() |
|||
Ordering needs to be fixed here too. |
|
|||
And here. |
|
|||
There are no open issues |
- Change Summary:
-
Make requested changes.
- Commits:
-
Summary ID 85216634555a41fc569e6725492b6605ca047d03 c2192b0a25ca7dbda6b00be338161d53dba203d9 - Diff:
-
Revision 2 (+540 -1858)
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Commits:
-
Summary ID c2192b0a25ca7dbda6b00be338161d53dba203d9 90aa0bd08ec450a53f427c3be03e5b8632de0a7d - Diff:
-
Revision 3 (+540 -1858)
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.