Summary

Remove long-deprecated callbacks style resource invocations.

Review Request #14158 — Created Sept. 11, 2024 and updated Sept. 12, 2024, 4:28 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

In Review Board 5, we added promises for our asynchronous operations in
our resource classes. We did this with fallbacks to handle old-style
calls that passed in callback methods. This change converts those
fallbacks to be errors instead.

Testing Done

Ran js-tests.

Commits

Summary	ID
Remove long-deprecated callbacks style resource invocations. In Review Board 5, we added promises for our asynchronous operations in our resource classes. We did this with fallbacks to handle old-style calls that passed in callback methods. This change converts those fallbacks to be errors instead. Testing Done: Ran js-tests.	85216634555a41fc569e6725492b6605ca047d03

Issues

Description	From	Last Updated
Copy paste-o: "fetchNext" -> "fetchAll"	maubin	Sept. 13, 2024, 8:57 a.m.
Copy paste-o: "DraftReview" -> "DraftReviewRequest"	maubin	Sept. 13, 2024, 8:57 a.m.

flake8 passed.

JSHint passed.

Ship it!

reviewboard/static/rb/js/common/resources/collections/resourceCollection.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Copy paste-o: "fetchNext" -> "fetchAll"
```
reviewboard/static/rb/js/common/resources/models/draftReviewRequestModel.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Copy paste-o: "DraftReview" -> "DraftReviewRequest"
```