Convert apiUtils to TypeScript.

 






 

 


  Review Request #14157
  —
  Created Sept. 11, 2024 and updated  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This change converts our API methods to TypeScript. Our apiUtils file

has a few methods, primary among them being apiCall. This change adds

typing for everything, and cleans up some old cruft. It does not yet

make any changes to the internals of how API requests work.


In order to facilitate using jasmine for unit tests. these methods are

all exported under a new top-level object called API.

 








  


 
 

  
    

  • Ran js-tests.
    • 

  • Smoke tested the UI and verified that things still worked correctly.
    • 


 







 









 





  








 




 







   

    
    
Changes between revision 2 and 3



    

 

 

 

 
orig
1
2
3

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Convert apiUtils to TypeScript.
     
This change converts our API methods to TypeScript. Our apiUtils file
has a few methods, primary among them being `apiCall`. This change adds
typing for everything, and cleans up some old cruft. It does not yet
make any changes to the internals of how API requests work.

In order to facilitate using jasmine for unit tests. these methods are
all exported under a new top-level object called `API`.

Testing Done:
- Ran js-tests.
- Smoke tested the UI and verified that things still worked correctly.

    

   
  		
  201e9d99dcada845bdde4bc279628f00f18b1eb9
  David Trowbridge
 


 
  
 
 
  
   
    

     Convert apiUtils to TypeScript.
     
This change converts our API methods to TypeScript. Our apiUtils file
has a few methods, primary among them being `apiCall`. This change adds
typing for everything, and cleans up some old cruft. It does not yet
make any changes to the internals of how API requests work.

In order to facilitate using jasmine for unit tests. these methods are
all exported under a new top-level object called `API`.

Testing Done:
- Ran js-tests.
- Smoke tested the UI and verified that things still worked correctly.

    

   
  		
  a657224ac9ce148f81fce048e852172f42ff500f
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/static/rb/js/common/resources/collections/repositoryCommitsCollection.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/common/utils/apiUtils.ts
     
    

   
  

 










     

    

   

  

  

   
   Loading...