Convert apiUtils to TypeScript.
Review Request #14157 — Created Sept. 11, 2024 and submitted — Latest diff uploaded
This change converts our API methods to TypeScript. Our apiUtils file
has a few methods, primary among them beingapiCall. This change adds
typing for everything, and cleans up some old cruft. It does not yet
make any changes to the internals of how API requests work.In order to facilitate using jasmine for unit tests. these methods are
all exported under a new top-level object calledAPI.
- Ran js-tests.
- Smoke tested the UI and verified that things still worked correctly.
Diff Revision 4 (Latest)
orig
1
2
3
4
Commits
Files
| reviewboard/staticbundles.py |
|---|
| reviewboard/static/rb/css/pages/base.less |
|---|
| reviewboard/static/rb/js/accountPrefsPage/views/oauthApplicationsView.ts |
|---|
| reviewboard/static/rb/js/accountPrefsPage/views/oauthTokensView.ts |
|---|
| reviewboard/static/rb/js/common/collections/baseCollection.ts |
|---|
| reviewboard/static/rb/js/common/resources/collections/repositoryCommitsCollection.ts |
|---|
| reviewboard/static/rb/js/common/resources/collections/resourceCollection.ts |
|---|
| reviewboard/static/rb/js/common/resources/models/baseResourceModel.ts |
|---|
| reviewboard/static/rb/js/common/resources/models/draftResourceChildModelMixin.ts |
|---|
| reviewboard/static/rb/js/common/resources/models/draftResourceModelMixin.ts |
|---|
| reviewboard/static/rb/js/common/resources/models/draftReviewModel.ts |
|---|
| reviewboard/static/rb/js/common/resources/models/draftReviewRequestModel.ts |
|---|
| reviewboard/static/rb/js/common/resources/models/reviewGroupModel.ts |
|---|
| reviewboard/static/rb/js/common/resources/models/reviewReplyModel.ts |
|---|
| reviewboard/static/rb/js/common/resources/models/reviewRequestModel.ts |
|---|
| reviewboard/static/rb/js/common/resources/models/tests/baseResourceModelTests.ts |
|---|
| reviewboard/static/rb/js/common/resources/models/tests/draftReviewRequestModelTests.ts |
|---|
| reviewboard/static/rb/js/common/resources/models/tests/reviewGroupModelTests.ts |
|---|
| reviewboard/static/rb/js/common/resources/models/tests/reviewReplyModelTests.ts |
|---|
| reviewboard/static/rb/js/common/resources/models/tests/reviewRequestModelTests.ts |
|---|