• 
      

    Only ignore node_modules at the top of the tree.

    Review Request #14147 — Created Sept. 6, 2024 and submitted

    Information

    Ink
    master

    Reviewers

    If there's a node_modules unintentionally created anywhere but at the
    top of the tree, it's possible for this to interfere with consumers of
    Ink. For example, Vite (used by Storybook) will consider it a candidate
    for module lookup, and could find stale modules.

    To make this problem more obvious, we no longer ignore node_modules
    anywhere but the top of the tree. git status will then report any
    stray copies, helping address the problem.

    Installed packages in a subdirectory and ran git status. Saw the
    stray `node_modules.

    Summary ID
    Only ignore node_modules at the top of the tree.
    If there's a `node_modules` unintentionally created anywhere but at the top of the tree, it's possible for this to interfere with consumers of Ink. For example, Vite (used by Storybook) will consider it a candidate for module lookup, and could find stale modules. To make this problem more obvious, we no longer ignore `node_modules` anywhere but the top of the tree. `git status` will then report any stray copies, helping address the problem.
    f25250eb9a64190b6606ed0a95fa7c7f89fc5282
    chipx86
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (ecbe2c1)