Summary

Only ignore node_modules at the top of the tree.

Review Request #14147 — Created Sept. 6, 2024 and submitted Sept. 13, 2024, 1:20 p.m.

Information

Owner

chipx86

Repository

Ink

Branch

master

Bugs

Depends On

Reviewers

Groups

beanbag-misc

People

Description

If there's a node_modules unintentionally created anywhere but at the
top of the tree, it's possible for this to interfere with consumers of
Ink. For example, Vite (used by Storybook) will consider it a candidate
for module lookup, and could find stale modules.

To make this problem more obvious, we no longer ignore node_modules
anywhere but the top of the tree. git status will then report any
stray copies, helping address the problem.

Testing Done

Installed packages in a subdirectory and ran git status. Saw the
stray `node_modules.

Commits

Summary	ID
Only ignore node_modules at the top of the tree. If there's a `node_modules` unintentionally created anywhere but at the top of the tree, it's possible for this to interfere with consumers of Ink. For example, Vite (used by Storybook) will consider it a candidate for module lookup, and could find stale modules. To make this problem more obvious, we no longer ignore `node_modules` anywhere but the top of the tree. `git status` will then report any stray copies, helping address the problem.	f25250eb9a64190b6606ed0a95fa7c7f89fc5282

Summary

Only ignore node_modules at the top of the tree.

If there's a `node_modules` unintentionally created anywhere but at the top of the tree, it's possible for this to interfere with consumers of Ink. For example, Vite (used by Storybook) will consider it a candidate for module lookup, and could find stale modules. To make this problem more obvious, we no longer ignore `node_modules` anywhere but the top of the tree. `git status` will then report any stray copies, helping address the problem.

f25250eb9a64190b6606ed0a95fa7c7f89fc5282

flake8 passed.

JSHint passed.

Change Summary:

Added a comment explaining why we're ignoring only the top-level node_modules.

Commits:

	Summary	ID
	Only ignore node_modules at the top of the tree. If there's a `node_modules` unintentionally created anywhere but at the top of the tree, it's possible for this to interfere with consumers of Ink. For example, Vite (used by Storybook) will consider it a candidate for module lookup, and could find stale modules. To make this problem more obvious, we no longer ignore `node_modules` anywhere but the top of the tree. `git status` will then report any stray copies, helping address the problem.	d417ee7080ade0f5511f52ed5b5a5b8adfc84fa5
	Only ignore node_modules at the top of the tree. If there's a `node_modules` unintentionally created anywhere but at the top of the tree, it's possible for this to interfere with consumers of Ink. For example, Vite (used by Storybook) will consider it a candidate for module lookup, and could find stale modules. To make this problem more obvious, we no longer ignore `node_modules` anywhere but the top of the tree. `git status` will then report any stray copies, helping address the problem.	f25250eb9a64190b6606ed0a95fa7c7f89fc5282

Diff:

Revision 2 (+10 -2)

Show changes

.gitignore

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (ecbe2c1)