Only ignore node_modules at the top of the tree.

 






 

 


  Review Request #14145
  —
  Created Sept. 5, 2024 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  Djblets
 









 
 

  release-5.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  djblets
 









 
 

  
 






 








 





  


 
 

  
If there's a node_modules unintentionally created anywhere but at the

top of the tree, it's possible for this to interfere with consumers of

Djblets. For example, Vite (used by Storybook) will consider it a

candidate for module lookup, and could find stale modules.


To make this problem more obvious, we no longer ignore node_modules

anywhere but the top of the tree. git status will then report any

stray copies, helping address the problem.

 








  


 
 

  
Installed packages in a subdirectory and ran git status. Saw the

stray `node_modules.

 







 









 





  








 




 







   

    
    
Diff Revision 1


This is not the most recent revision of the diff. The latest diff is revision 2. See what's changed.

    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Only ignore node_modules at the top of the tree.
     
If there's a `node_modules` unintentionally created anywhere but at the
top of the tree, it's possible for this to interfere with consumers of
Djblets. For example, Vite (used by Storybook) will consider it a
candidate for module lookup, and could find stale modules.

To make this problem more obvious, we no longer ignore `node_modules`
anywhere but the top of the tree. `git status` will then report any
stray copies, helping address the problem.

    

   
  		
  875db4468d2acb2a6e6d197d0530ec1e592a4742
  Christian Hammond
 




    


    


      
Files


      

 
  
 
 
  .gitignore
  
 
 
  
   

  
 		


    

    

   

  

 









 

  

   
    

     
      
      .gitignore
     
    

   
  

 










     

    

   

  

  

   
   Loading...