Summary

Only ignore node_modules at the top of the tree.

Review Request #14145 — Created Sept. 5, 2024 and submitted Sept. 14, 2024, 12:31 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-5.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

If there's a node_modules unintentionally created anywhere but at the
top of the tree, it's possible for this to interfere with consumers of
Djblets. For example, Vite (used by Storybook) will consider it a
candidate for module lookup, and could find stale modules.

To make this problem more obvious, we no longer ignore node_modules
anywhere but the top of the tree. git status will then report any
stray copies, helping address the problem.

Testing Done

Installed packages in a subdirectory and ran git status. Saw the
stray `node_modules.

Commits

Summary	ID
Only ignore node_modules at the top of the tree. If there's a `node_modules` unintentionally created anywhere but at the top of the tree, it's possible for this to interfere with consumers of Djblets. For example, Vite (used by Storybook) will consider it a candidate for module lookup, and could find stale modules. To make this problem more obvious, we no longer ignore `node_modules` anywhere but the top of the tree. `git status` will then report any stray copies, helping address the problem.	0ba85159d5c2f8a130f541e6aeb56ae8b88008b6

Summary

Only ignore node_modules at the top of the tree.

If there's a `node_modules` unintentionally created anywhere but at the top of the tree, it's possible for this to interfere with consumers of Djblets. For example, Vite (used by Storybook) will consider it a candidate for module lookup, and could find stale modules. To make this problem more obvious, we no longer ignore `node_modules` anywhere but the top of the tree. `git status` will then report any stray copies, helping address the problem.

0ba85159d5c2f8a130f541e6aeb56ae8b88008b6

Issues

Description	From	Last Updated
Can you add a comment about why this one is specifically relative? I don't want to come back years from …	david	Sept. 9, 2024, 5:17 p.m.

flake8 passed.

JSHint passed.

.gitignore (Diff revision 1)

The issue has been resolved. Show all issues

Can you add a comment about why this one is specifically relative? I don't want to come back years from now and "clean up" this file.

Same with the other similar changes.

Change Summary:

Added a comment explaining why we're ignoring only the top-level node_modules.

Commits:

	Summary	ID
	Only ignore node_modules at the top of the tree. If there's a `node_modules` unintentionally created anywhere but at the top of the tree, it's possible for this to interfere with consumers of Djblets. For example, Vite (used by Storybook) will consider it a candidate for module lookup, and could find stale modules. To make this problem more obvious, we no longer ignore `node_modules` anywhere but the top of the tree. `git status` will then report any stray copies, helping address the problem.	875db4468d2acb2a6e6d197d0530ec1e592a4742
	Only ignore node_modules at the top of the tree. If there's a `node_modules` unintentionally created anywhere but at the top of the tree, it's possible for this to interfere with consumers of Djblets. For example, Vite (used by Storybook) will consider it a candidate for module lookup, and could find stale modules. To make this problem more obvious, we no longer ignore `node_modules` anywhere but the top of the tree. `git status` will then report any stray copies, helping address the problem.	0ba85159d5c2f8a130f541e6aeb56ae8b88008b6

Diff:

Revision 2 (+10 -2)

Show changes

.gitignore

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-5.x (f82960f)