Use a <table> for the related users option list.

Review Request #14135 — Created Sept. 2, 2024 and submitted — Latest diff uploaded

Information

Review Board
release-7.x

Reviewers

For the set of selected users when using a related users selector
widget, things were wrapping in terrible ways if there were long
usernames or real names. This change builds on a change in Djblets to
use a <table> for the layout of the options instead of a <ul>.

While in here, I also decided to make the widget a bit bigger, because
it was pretty small even for reasonable-sized desktop windows.

Created some users with very long names and added them to a group. Saw
that the users selector widget no longer looked terrible.

Diff Revision 2 (Latest)

orig
1
2

Commits

First Last Summary ID Author
Use a <table> for the related users option list.
For the set of selected users when using a related users selector widget, things were wrapping in terrible ways if there were long usernames or real names. This change builds on a change in Djblets to use a <table> for the layout of the options instead of a <ul>. While in here, I also decided to make the widget a bit bigger, because it was pretty small even for reasonable-sized desktop windows. Testing Done: Created some users with very long names and added them to a group. Saw that the users selector widget no longer looked terrible.
64fe321bcd37f401f224eae3cfca6c70c3956646 David Trowbridge
reviewboard/static/rb/css/pages/admin/widgets.less
reviewboard/static/rb/js/admin/views/relatedUserSelectorView.es6.js
Loading...