Make the unified banner's mode selector work on mobile.

Review Request #14129 — Created Aug. 29, 2024 and submitted — Latest diff uploaded

Information

Review Board
release-7.x

Reviewers

The unified banner's mode selector wasn't working on mobile, the menu
wouldn't open on touch. This is because the mode menu didn't specifically
handle touch events. We now handle touch events and make sure the menu
works as normal on mobile.

  • Opened and closed the menu on mobile, tapping on different parts of it
    (the label, icon, empty space).
  • Switched between menu modes by clicking on the menu items.
  • Made sure the menu still worked on desktop.

Diff Revision 1 (Latest)

Commits

First Last Summary ID Author
Make the unified banner's mode selector work on mobile.
The unified banner's mode selector wasn't working on mobile, the menu wouldn't open on touch. This is because the mode menu didn't specifically handle touch events. We now handle touch events and make sure the menu works as normal on mobile. Testing Done: - Opened and closed the menu on mobile, tapping on different parts of it (the label, icon, empty space). - Switched between menu modes by clicking on the menu items. - Made sure the menu still worked on desktop.
06e47d6d6b7a444d59087fa123d5c2daa97bd81d Michelle Aubin
reviewboard/static/rb/css/ui/banners.less
reviewboard/static/rb/js/reviews/views/unifiedBannerView.ts
Loading...