• 
      

    Make the unified banner's mode selector work on mobile.

    Review Request #14129 — Created Aug. 29, 2024 and submitted

    Information

    Review Board
    release-7.x

    Reviewers

    The unified banner's mode selector wasn't working on mobile, the menu
    wouldn't open on touch. This is because the mode menu didn't specifically
    handle touch events. We now handle touch events and make sure the menu
    works as normal on mobile.

    • Opened and closed the menu on mobile, tapping on different parts of it
      (the label, icon, empty space).
    • Switched between menu modes by clicking on the menu items.
    • Made sure the menu still worked on desktop.
    Summary ID
    Make the unified banner's mode selector work on mobile.
    The unified banner's mode selector wasn't working on mobile, the menu wouldn't open on touch. This is because the mode menu didn't specifically handle touch events. We now handle touch events and make sure the menu works as normal on mobile. Testing Done: - Opened and closed the menu on mobile, tapping on different parts of it (the label, icon, empty space). - Switched between menu modes by clicking on the menu items. - Made sure the menu still worked on desktop.
    06e47d6d6b7a444d59087fa123d5c2daa97bd81d
    david
    1. Ship It!
    2. 
        
    chipx86
    1. Ship It!
    2. 
        
    maubin
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-7.x (a930cb3)