Summary

Do some cleanup and modernization of hosting service/API code.

Review Request #14127 — Created Aug. 29, 2024 and submitted Sept. 2, 2024, 9:48 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

In preparation for fixing issues with the HostingServiceAccountResource
create method, this change does some cleanup and type annotation for
code I'm touching.

Testing Done

Ran unit tests.

Commits

Summary	ID
Do some cleanup and modernization of hosting service/API code. In preparation for fixing issues with the HostingServiceAccountResource create method, this change does some cleanup and type annotation for code I'm touching. Testing Done: Ran unit tests.	9ff0cc1fb1031cff46890604ea7f3258bcf5b92e

Issues

Description	From	Last Updated
line too long (81 > 79 characters) Column: 80 Error code: E501	reviewbot	Aug. 29, 2024, 9:02 a.m.
line too long (81 > 79 characters) Column: 80 Error code: E501	reviewbot	Aug. 29, 2024, 9:02 a.m.
Nit but could say "The HTTP request from the client." to be more clear.	maubin	Aug. 30, 2024, 9:29 a.m.
Forgot to document **kwargs	maubin	Aug. 30, 2024, 9:28 a.m.
This is missing Args and Returns sections.	maubin	Aug. 30, 2024, 9:28 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/webapi/tests/test_hosting_service_account.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (81 > 79 characters)

Column: 80
Error code: E501
```
reviewboard/webapi/tests/test_hosting_service_account.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (81 > 79 characters)

Column: 80
Error code: E501
```

Commits:

	Summary	ID
	Do some cleanup and modernization of hosting service/API code. In preparation for fixing issues with the HostingServiceAccountResource create method, this change does some cleanup and type annotation for code I'm touching. Testing Done: Ran unit tests.	ab9c0dc94e5789236bd0d50b3af86c7a4d3b1d6b
	Do some cleanup and modernization of hosting service/API code. In preparation for fixing issues with the HostingServiceAccountResource create method, this change does some cleanup and type annotation for code I'm touching. Testing Done: Ran unit tests.	2302ef81ea14ec8ad482739044ebbd8a2d661bf4

Diff:

Revision 2 (+1056 -120)

Show changes

	reviewboard/hostingsvcs/managers.py
	reviewboard/hostingsvcs/models.py
	reviewboard/webapi/resources/hosting_service_account.py
	reviewboard/webapi/tests/test_hosting_service_account.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/webapi/resources/hosting_service_account.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Nit but could say "The HTTP request from the client." to be more clear.
```

reviewboard/webapi/resources/hosting_service_account.py (Diff revision 2)

The issue has been resolved. Show all issues

Forgot to document **kwargs

reviewboard/webapi/resources/hosting_service_account.py (Diff revision 2)

The issue has been dropped. Show all issues

This is missing Args and Returns sections.

david Aug. 30, 2024, 9:29 a.m.

At the moment, the docstrings for these are extracted and used to create the public API documentation, so we don't have any "codebase" kind of docs here. My changes for @webapi_docs change that so we can have the public docs in the decorator and use the docstring for our code, but that's not in yet and won't be for 7.x.

maubin Aug. 30, 2024, 11:12 a.m.
```
Oh I see.
```

Commits:

	Summary	ID
	Do some cleanup and modernization of hosting service/API code. In preparation for fixing issues with the HostingServiceAccountResource create method, this change does some cleanup and type annotation for code I'm touching. Testing Done: Ran unit tests.	2302ef81ea14ec8ad482739044ebbd8a2d661bf4
	Do some cleanup and modernization of hosting service/API code. In preparation for fixing issues with the HostingServiceAccountResource create method, this change does some cleanup and type annotation for code I'm touching. Testing Done: Ran unit tests.	9ff0cc1fb1031cff46890604ea7f3258bcf5b92e

Diff:

Revision 3 (+1062 -120)

Show changes

	reviewboard/hostingsvcs/managers.py
	reviewboard/hostingsvcs/models.py
	reviewboard/webapi/resources/hosting_service_account.py
	reviewboard/webapi/tests/test_hosting_service_account.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

Status:: Completed
Change Summary:: Pushed to release-7.x (c4538b4)