Add a mobile mode attribute to the review request editor view.

Review Request #14126 — Created Aug. 28, 2024 and submitted — Latest diff uploaded

Information

Review Board
release-7.x

Reviewers

A inMobileMode attribute already exists on the base PageView class for
letting views know whether they're being viewed on a mobile device. This
change plumbs that attribute through to the ReviewRequestEditorView. This
will be useful in an upcoming change for fixing file attachment actions
on mobile, and is generally useful if we need to do any mobile specific
behaviour on the review request editor view or any other views attached
to it in the future.

  • Ran JS unit tests.
  • Used in an upcoming change.

Changes between revision 1 and 2

orig
1
2

Commits

Summary ID Author
Add a mobile mode attribute to the review request editor view.
A `inMobileMode` attribute already exists on the base `PageView` class for letting views know whether they're being viewed on a mobile device. This change plumbs that attribute through to the `ReviewRequestEditorView`. This will be useful in an upcoming change for fixing file attachment actions on mobile, and is generally useful if we need to do any mobile specific behaviour on the review request editor view or any other views attached to it in the future.
ef267d97ed2d3ae9730d279b42112d6f1ca9d9bc Michelle Aubin
Add a mobile mode attribute to the review request editor view.
A `inMobileMode` attribute already exists on the base `PageView` class for letting views know whether they're being viewed on a mobile device. This change plumbs that attribute through to the `ReviewRequestEditorView`. This will be useful in an upcoming change for fixing file attachment actions on mobile, and is generally useful if we need to do any mobile specific behaviour on the review request editor view or any other views attached to it in the future.
1a27423de8b3067b6eaa9b81d257844216971ca3 Michelle Aubin
reviewboard/static/rb/js/reviews/views/reviewRequestEditorView.ts
reviewboard/static/rb/js/reviews/views/reviewablePageView.ts
Loading...