Summary

Add a mobile mode attribute to the review request editor view.

Review Request #14126 — Created Aug. 28, 2024 and submitted Sept. 6, 2024, 9:38 a.m.

Information

Owner

maubin

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

Blocks

14125

Reviewers

Groups

reviewboard

People

Description

A inMobileMode attribute already exists on the base PageView class for

letting views know whether they're being viewed on a mobile device. This

change plumbs that attribute through to the ReviewRequestEditorView. This

will be useful in an upcoming change for fixing file attachment actions

on mobile, and is generally useful if we need to do any mobile specific

behaviour on the review request editor view or any other views attached

to it in the future.

Testing Done


Ran JS unit tests.
Used in an upcoming change.

Commits

Summary	ID
Add a mobile mode attribute to the review request editor view. A `inMobileMode` attribute already exists on the base `PageView` class for letting views know whether they're being viewed on a mobile device. This change plumbs that attribute through to the `ReviewRequestEditorView`. This will be useful in an upcoming change for fixing file attachment actions on mobile, and is generally useful if we need to do any mobile specific behaviour on the review request editor view or any other views attached to it in the future.	1a27423de8b3067b6eaa9b81d257844216971ca3

Summary

Add a mobile mode attribute to the review request editor view.

A `inMobileMode` attribute already exists on the base `PageView` class for letting views know whether they're being viewed on a mobile device. This change plumbs that attribute through to the `ReviewRequestEditorView`. This will be useful in an upcoming change for fixing file attachment actions on mobile, and is generally useful if we need to do any mobile specific behaviour on the review request editor view or any other views attached to it in the future.

1a27423de8b3067b6eaa9b81d257844216971ca3

Issues

Description	From	Last Updated
Let's put the > { on the next line.	david	Sept. 3, 2024, 10:04 a.m.
Options isn't really meant to be a place to store mutable state. It's probably better to have inMobileMode be a …	david	Sept. 3, 2024, 10:07 a.m.
Can you add a Version Added to these?	chipx86	Sept. 6, 2024, 9:34 a.m.
Here, too.	chipx86	Sept. 6, 2024, 9:37 a.m.

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/reviews/views/reviewRequestEditorView.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Let's put the > { on the next line.
```

reviewboard/static/rb/js/reviews/views/reviewablePageView.ts (Diff revision 1)

The issue has been resolved. Show all issues

Options isn't really meant to be a place to store mutable state. It's probably better to have inMobileMode be a member that can be initialized by passing it in through options.

Change Summary:

Added an actual inMobileMode attribute instead of accessing it from options.

Commits:

	Summary	ID
	Add a mobile mode attribute to the review request editor view. A `inMobileMode` attribute already exists on the base `PageView` class for letting views know whether they're being viewed on a mobile device. This change plumbs that attribute through to the `ReviewRequestEditorView`. This will be useful in an upcoming change for fixing file attachment actions on mobile, and is generally useful if we need to do any mobile specific behaviour on the review request editor view or any other views attached to it in the future.	ef267d97ed2d3ae9730d279b42112d6f1ca9d9bc
	Add a mobile mode attribute to the review request editor view. A `inMobileMode` attribute already exists on the base `PageView` class for letting views know whether they're being viewed on a mobile device. This change plumbs that attribute through to the `ReviewRequestEditorView`. This will be useful in an upcoming change for fixing file attachment actions on mobile, and is generally useful if we need to do any mobile specific behaviour on the review request editor view or any other views attached to it in the future.	1a27423de8b3067b6eaa9b81d257844216971ca3