Improve file actions on mobile.

Review Request #14125 — Created Aug. 28, 2024 and submitted — Latest diff uploaded

Information

Review Board
release-7.x

Reviewers

On mobile, file actions were being displayed mostly off screen, to the
right or left of the file attachment thumbnail. This change fixes things
by displaying the file actions below the file thumbnail. We also make
sure to hide the actions if the user opens the caption editor.

  • Tested using file actions on mobile and desktop.
  • Tested opening the caption editor while file actions are open.
  • Tested tapping and hovering on multiple different thumbnails, opening
    and closing file actions for each.

Diff Revision 3 (Latest)

orig
1
2
3

Commits

First Last Summary ID Author
Improve file actions on mobile.
On mobile, file actions were being displayed mostly off screen, to the right or left of the file attachment thumbnail. This change fixes things by displaying the file actions below the file thumbnail. We also make sure to hide the actions if the user opens the caption editor. Testing Done: - Tested using file actions on mobile and desktop. - Tested opening the caption editor while file actions are open. - Tested tapping and hovering on multiple different thumbnails, opening and closing file actions for each.
7bcefc085aa20343a4b5eed8a10b73bfe240da13 Michelle Aubin
reviewboard/static/rb/css/pages/reviews.less
reviewboard/static/rb/js/reviews/views/fileAttachmentThumbnailView.ts
Loading...