Improve file actions on mobile.

Review Request #14125 — Created Aug. 28, 2024 and submitted — Latest diff uploaded

Information

Review Board
release-7.x

Reviewers

On mobile, file actions were being displayed mostly off screen, to the
right or left of the file attachment thumbnail. This change fixes things
by displaying the file actions below the file thumbnail. We also make
sure to hide the actions if the user opens the caption editor.

  • Tested using file actions on mobile and desktop.
  • Tested opening the caption editor while file actions are open.
  • Tested tapping and hovering on multiple different thumbnails, opening
    and closing file actions for each.

Changes between revision 1 and 2

orig
1
2
3

Commits

Summary ID Author
Improve file actions on mobile.
On mobile, file actions were being displayed mostly off screen, to the right or left of the file attachment thumbnail. This change fixes things by displaying the file actions below the file thumbnail. We also make sure to hide the actions if the user opens the caption editor. Testing Done: - Tested using file actions on mobile and desktop. - Tested opening the caption editor while file actions are open. - Tested tapping and hovering on multiple different thumbnails, opening and closing file actions for each.
b8179b1ff2dd55912d4dbaefacfe80c07a6bcf57 Michelle Aubin
Improve file actions on mobile.
On mobile, file actions were being displayed mostly off screen, to the right or left of the file attachment thumbnail. This change fixes things by displaying the file actions below the file thumbnail. We also make sure to hide the actions if the user opens the caption editor. Testing Done: - Tested using file actions on mobile and desktop. - Tested opening the caption editor while file actions are open. - Tested tapping and hovering on multiple different thumbnails, opening and closing file actions for each.
d9832aa25d69a6863b5aef8f3fada785f9158514 Michelle Aubin
reviewboard/static/rb/js/reviews/views/fileAttachmentThumbnailView.ts
Loading...