Summary

Improve file actions on mobile.

Review Request #14125 — Created Aug. 28, 2024 and submitted Sept. 6, 2024, 10:13 a.m.

Information

Owner

maubin

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

~~14126~~

Reviewers

Groups

reviewboard

People

Description

Testing Done


Tested using file actions on mobile and desktop.
Tested opening the caption editor while file actions are open.
Tested tapping and hovering on multiple different thumbnails, opening

  and closing file actions for each.

Commits

Summary	ID
Improve file actions on mobile. On mobile, file actions were being displayed mostly off screen, to the right or left of the file attachment thumbnail. This change fixes things by displaying the file actions below the file thumbnail. We also make sure to hide the actions if the user opens the caption editor. Testing Done: - Tested using file actions on mobile and desktop. - Tested opening the caption editor while file actions are open. - Tested tapping and hovering on multiple different thumbnails, opening and closing file actions for each.	7bcefc085aa20343a4b5eed8a10b73bfe240da13

Summary

Improve file actions on mobile.

On mobile, file actions were being displayed mostly off screen, to the right or left of the file attachment thumbnail. This change fixes things by displaying the file actions below the file thumbnail. We also make sure to hide the actions if the user opens the caption editor. Testing Done: - Tested using file actions on mobile and desktop. - Tested opening the caption editor while file actions are open. - Tested tapping and hovering on multiple different thumbnails, opening and closing file actions for each.

7bcefc085aa20343a4b5eed8a10b73bfe240da13

Files

Issues

Description	From	Last Updated
Let's sort these alphabetically.	david	Sept. 3, 2024, 5:41 p.m.
We only use this once. Can we just put it inline in the conditional instead of defining a variable for …	david	Sept. 3, 2024, 5:42 p.m.

flake8 passed.

JSHint passed.

Change Summary:

Updated for the new inMobileMode attribute added in /r/14126/

Commits:

	Summary	ID
	Improve file actions on mobile. On mobile, file actions were being displayed mostly off screen, to the right or left of the file attachment thumbnail. This change fixes things by displaying the file actions below the file thumbnail. We also make sure to hide the actions if the user opens the caption editor. Testing Done: - Tested using file actions on mobile and desktop. - Tested opening the caption editor while file actions are open. - Tested tapping and hovering on multiple different thumbnails, opening and closing file actions for each.	b8179b1ff2dd55912d4dbaefacfe80c07a6bcf57
	Improve file actions on mobile. On mobile, file actions were being displayed mostly off screen, to the right or left of the file attachment thumbnail. This change fixes things by displaying the file actions below the file thumbnail. We also make sure to hide the actions if the user opens the caption editor. Testing Done: - Tested using file actions on mobile and desktop. - Tested opening the caption editor while file actions are open. - Tested tapping and hovering on multiple different thumbnails, opening and closing file actions for each.	d9832aa25d69a6863b5aef8f3fada785f9158514

Diff:

Revision 2 (+54 -26)

Show changes

	reviewboard/static/rb/css/pages/reviews.less
	reviewboard/static/rb/js/reviews/views/fileAttachmentThumbnailView.ts

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/static/rb/css/pages/reviews.less (Diff revision 2)
The issue has been resolved. Show all issues
```
Let's sort these alphabetically.
```
reviewboard/static/rb/js/reviews/views/fileAttachmentThumbnailView.ts (Diff revision 2)
The issue has been resolved. Show all issues
```
We only use this once. Can we just put it inline in the conditional instead of defining a variable for it?
```

Commits:

	Summary	ID
	Improve file actions on mobile. On mobile, file actions were being displayed mostly off screen, to the right or left of the file attachment thumbnail. This change fixes things by displaying the file actions below the file thumbnail. We also make sure to hide the actions if the user opens the caption editor. Testing Done: - Tested using file actions on mobile and desktop. - Tested opening the caption editor while file actions are open. - Tested tapping and hovering on multiple different thumbnails, opening and closing file actions for each.	d9832aa25d69a6863b5aef8f3fada785f9158514
	Improve file actions on mobile. On mobile, file actions were being displayed mostly off screen, to the right or left of the file attachment thumbnail. This change fixes things by displaying the file actions below the file thumbnail. We also make sure to hide the actions if the user opens the caption editor. Testing Done: - Tested using file actions on mobile and desktop. - Tested opening the caption editor while file actions are open. - Tested tapping and hovering on multiple different thumbnails, opening and closing file actions for each.	7bcefc085aa20343a4b5eed8a10b73bfe240da13

Diff:

Revision 3 (+50 -26)

Show changes

	reviewboard/static/rb/css/pages/reviews.less
	reviewboard/static/rb/js/reviews/views/fileAttachmentThumbnailView.ts

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.x (c85a124)