Summary

Clean up and modernize code in repository API tests.

Review Request #14124 — Created Aug. 27, 2024 and submitted Sept. 2, 2024, 9:48 a.m.

Owner

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

Groups

People

Description

This change cleans up the test_repository.py file in several ways:

Ensure we have type hints everywhere.
Add missing docstrings.
Consistently use @webapi_test_template (including fixing one place
where we had a typo in "<URL>").

Testing Done

Ran tests in this file.

Commits

Summary	ID
Clean up and modernize code in repository API tests. This change cleans up the test_repository.py file in several ways: - Ensure we have type hints everywhere. - Add missing docstrings. - Consistently use @webapi_test_template (including fixing one place where we had a typo in "<URL>"). Testing Done: Ran tests in this file.	781463c2a6982cc829a32b4e3c3a8a23f8e98594

Issues

Description	From	Last Updated
This can be JSONDict.	maubin	Aug. 29, 2024, 8:57 a.m.
This can also be JSONDict. Same with any other response dicts.	maubin	Aug. 29, 2024, 8:57 a.m.

flake8 passed.

JSHint passed.

reviewboard/webapi/tests/test_repository.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This can be JSONDict.
```
reviewboard/webapi/tests/test_repository.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This can also be JSONDict. Same with any other response dicts.
```

Commits:

	Summary	ID
	Clean up and modernize code in repository API tests. This change cleans up the test_repository.py file in several ways: - Ensure we have type hints everywhere. - Add missing docstrings. - Consistently use @webapi_test_template (including fixing one place where we had a typo in "<URL>"). Testing Done: Ran tests in this file.	16273145887e0b898fcc1fa9efe399c051862389
	Clean up and modernize code in repository API tests. This change cleans up the test_repository.py file in several ways: - Ensure we have type hints everywhere. - Add missing docstrings. - Consistently use @webapi_test_template (including fixing one place where we had a typo in "<URL>"). Testing Done: Ran tests in this file.	781463c2a6982cc829a32b4e3c3a8a23f8e98594

Diff:

Revision 2 (+824 -222)

flake8 passed.

JSHint passed.

Ship it!