• 
      

    Fix search results page in dark mode.

    Review Request #14121 — Created Aug. 26, 2024 and submitted

    Information

    Review Board
    release-7.x

    Reviewers

    The search feature is extremely unloved, and had a ton of hardcoded
    style rules. These didn't work at all in dark mode, and had some ugly
    behavior even in light mode (user results would only take up a small
    amount of horizontal space and were inline blocks, causing the next
    result to wrap adjacent to it).

    This change simplifies the display somewhat (especially for user
    results), and makes it so all our styling is based on our ink variables
    instead of hardcoding colors and sizes.

    I'd love to do a real revamp of the search UI entirely, but for now this
    is much more usable, especially in dark mode.

    Looked at search results that included both users and review requests
    and saw that everything looked nice in both light and dark modes.

    Summary ID
    Fix search results page in dark mode.
    The search feature is extremely unloved, and had a ton of hardcoded style rules. These didn't work at all in dark mode, and had some ugly behavior even in light mode (user results would only take up a small amount of horizontal space and were inline blocks, causing the next result to wrap adjacent to it). This change simplifies the display somewhat (especially for user results), and makes it so all our styling is based on our ink variables instead of hardcoding colors and sizes. I'd love to do a real revamp of the search UI entirely, but for now this is much more usable, especially in dark mode. Testing Done: Looked at search results that included both users and review requests and saw that everything looked nice in both light and dark modes.
    0e603324f6ad296676f3903d9f26a2ef5de591d1

    maubin
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-7.x (02e2a47)