Convert Djblets use of $.modalBox to Ink.Dialog.

 






 

 


  Review Request #14104
  —
  Created Aug. 14, 2024 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Djblets
 









 
 

  release-6.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  djblets
 









 
 

  
 






 








 





  


 
 

  
Djblets had only one place that was using our old $.modalBox

implementation: the integration config list. This change swaps that out

for the new Ink.Dialog component.

 








  


 
 

  
    

  • Ran js-tests.
    • 

  • Used the delete action for integration configs, with both the confirm
    
  and cancel responses.
    • 


 







 









 





  








 




 







   

    
    
Diff Revision 2 (Latest)



    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Convert Djblets use of $.modalBox to Ink.Dialog.
     
Djblets had only one place that was using our old `$.modalBox`
implementation: the integration config list. This change swaps that out
for the new Ink.Dialog component.

Testing Done:
- Ran js-tests.
- Used the delete action for integration configs, with both the confirm
  and cancel responses.

    

   
  		
  a67eb646d167160534c397943ff82ffc2c79112e
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      rollup.config.js
     
    

   
  

 



 

  

   
    

     
      
      djblets/static/djblets/js/integrations/views/integrationConfigListView.ts
     
    

   
  

 



 

  

   
    

     
      
      djblets/static/djblets/js/integrations/views/tests/integrationConfigListViewTests.ts
     
    

   
  

 










     

    

   

  

  

   
   Loading...