This change has been marked as completed.

Describe the completed change (optional):

Pushed to release-6.x (6402ad7)

Summary

Convert Djblets use of $.modalBox to Ink.Dialog.

Review Request #14104 — Created Aug. 14, 2024 and submitted 2 months, 1 week ago

Information

Owner

david*

Repository

Djblets

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description*

Djblets had only one place that was using our old $.modalBox
implementation: the integration config list. This change swaps that out
for the new Ink.Dialog component.

Testing Done


Ran js-tests.
Used the delete action for integration configs, with both the confirm

  and cancel responses.

Commits

Summary	ID
Convert Djblets use of $.modalBox to Ink.Dialog. Djblets had only one place that was using our old `$.modalBox` implementation: the integration config list. This change swaps that out for the new Ink.Dialog component. Testing Done: - Ran js-tests. - Used the delete action for integration configs, with both the confirm and cancel responses.	a67eb646d167160534c397943ff82ffc2c79112e

Description	From	Last Updated
There are no open issues

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Change Summary:

Use new dialog actions.

Commits:

	Summary	ID
	Convert Djblets use of $.modalBox to Ink.Dialog. Djblets had only one place that was using our old `$.modalBox` implementation: the integration config list. This change swaps that out for the new Ink.Dialog component. Testing Done: - Ran js-tests. - Used the delete action for integration configs, with both the confirm and cancel responses.	d95f55d9e7554e40fd7b8e07123c1a5fe319ecd5
	Convert Djblets use of $.modalBox to Ink.Dialog. Djblets had only one place that was using our old `$.modalBox` implementation: the integration config list. This change swaps that out for the new Ink.Dialog component. Testing Done: - Ran js-tests. - Used the delete action for integration configs, with both the confirm and cancel responses.	a67eb646d167160534c397943ff82ffc2c79112e

Diff:

Revision 2 (+122 -62)

Show changes

	rollup.config.js
	djblets/static/djblets/js/integrations/views/integrationConfigListView.ts
	djblets/static/djblets/js/integrations/views/tests/integrationConfigListViewTests.ts

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-6.x (6402ad7)