Summary

Port integration config views to TypeScript/spina.

Review Request #14103 — Created Aug. 14, 2024 and submitted Sept. 10, 2024, 8:24 a.m.

Information

Owner

david

Repository

Djblets

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

This change converts the integration config list view and pop-up to
TypeScript and spina.

This also makes a few small updates to our packaging for djblets to
include jasmine-suites as a dependency. This was used in djblets but not
included in any of our build stuff. It didn't actually matter for
runtime use when running the tests via our RB js-tests endpoint, but
it's necessary for running the TS compiler for files that import
jasmine within the djblets directory.

Testing Done


Ran js-tests.
Added, edited, and deleted integration configs.

Commits

Summary	ID
Port integration config views to TypeScript/spina. This change converts the integration config list view and pop-up to TypeScript and spina. This also makes a few small updates to our packaging for djblets to include jasmine-suites as a dependency. This was used in djblets but not included in any of our build stuff. It didn't actually matter for runtime use when running the tests via our RB js-tests endpoint, but it's necessary for running the TS compiler for files that import jasmine within the djblets directory. Testing Done: - Ran js-tests. - Added, edited, and deleted integration configs.	763e6457c5ba835d114c6d2cfd5f0bc8f80edf00

Summary

Port integration config views to TypeScript/spina.

This change converts the integration config list view and pop-up to TypeScript and spina. This also makes a few small updates to our packaging for djblets to include jasmine-suites as a dependency. This was used in djblets but not included in any of our build stuff. It didn't actually matter for runtime use when running the tests via our RB js-tests endpoint, but it's necessary for running the TS compiler for files that import jasmine within the djblets directory. Testing Done: - Ran js-tests. - Added, edited, and deleted integration configs.

763e6457c5ba835d114c6d2cfd5f0bc8f80edf00

Issues

Description	From	Last Updated
This is missing Version Added.	chipx86	Aug. 26, 2024, 2:48 p.m.
Missing docs.	chipx86	Aug. 26, 2024, 2:48 p.m.
Can you sort these alphabetically?	chipx86	Aug. 26, 2024, 2:48 p.m.
This is an API breakage without a deprecation notice. We should at least provide a forwarding function.	chipx86	Aug. 26, 2024, 4:31 p.m.
Same here.	chipx86	Aug. 26, 2024, 4:31 p.m.

flake8 passed.

JSHint passed.

djblets/static/djblets/js/integrations/views/addIntegrationPopupView.ts (Diff revision 1)

The issue has been resolved. Show all issues

This is missing Version Added.

djblets/static/djblets/js/integrations/views/addIntegrationPopupView.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Missing docs.
```

djblets/static/djblets/js/integrations/views/addIntegrationPopupView.ts (Diff revision 1)

The issue has been resolved. Show all issues

Can you sort these alphabetically?

djblets/static/djblets/js/integrations/views/addIntegrationPopupView.ts (Diff revision 1)

The issue has been resolved. Show all issues

This is an API breakage without a deprecation notice. We should at least provide a forwarding function.

david Aug. 26, 2024, 4:31 p.m.

I guess if I have to deal with TS errors either way I'd prefer to just keep the old names. That said, I feel like it's highly unlikely that there's any use of this other than from within IntegrationConfigListView.

djblets/static/djblets/js/integrations/views/addIntegrationPopupView.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Same here.
```

Commits:

	Summary	ID
	Port integration config views to TypeScript/spina. This change converts the integration config list view and pop-up to TypeScript and spina. This also makes a few small updates to our packaging for djblets to include jasmine-suites as a dependency. This was used in djblets but not included in any of our build stuff. It didn't actually matter for runtime use when running the tests via our RB js-tests endpoint, but it's necessary for running the TS compiler for files that import jasmine within the djblets directory. Testing Done: - Ran js-tests. - Added, edited, and deleted integration configs.	58ab2c4bf5aff435950d6a61864aac5918e7b577
	Port integration config views to TypeScript/spina. This change converts the integration config list view and pop-up to TypeScript and spina. This also makes a few small updates to our packaging for djblets to include jasmine-suites as a dependency. This was used in djblets but not included in any of our build stuff. It didn't actually matter for runtime use when running the tests via our RB js-tests endpoint, but it's necessary for running the TS compiler for files that import jasmine within the djblets directory. Testing Done: - Ran js-tests. - Added, edited, and deleted integration configs.	763e6457c5ba835d114c6d2cfd5f0bc8f80edf00

Diff:

Revision 2 (+616 -212)

Show changes

	package-lock.json
	rollup.config.js
	djblets/dependencies.py
	djblets/package.json
	djblets/staticbundles.py
	djblets/static/djblets/js/integrations/index.ts
	djblets/static/djblets/js/integrations/views/addIntegrationPopupView.es6.js
	djblets/static/djblets/js/integrations/views/index.ts
	5 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-6.x (5ebb733)