This change has been marked as completed.

Describe the completed change (optional):

Pushed to master (b38804f)

Summary

Convert RB.DiffFragmentView to TypeScript/spina.

Review Request #14099 — Created Aug. 9, 2024 and submitted 1 week, 6 days ago

Owner

Repository

Review Board

Branch

master

Bugs

Depends On

Groups

People

Description*

This change converts RB.DiffFragmentView to TypeScript.

Testing Done


Ran js-tests.
Tested diff fragment loading in various situations.

Commits

Summary	ID
Convert RB.DiffFragmentView to TypeScript/spina. This change converts RB.DiffFragmentView to TypeScript. Testing Done: - Ran js-tests. - Tested diff fragment loading in various situations.	9a0cddd3c403b9979a78da383c1add5c341b3272

Issues

Description	From	Last Updated
We usually have the optional attributes below the required ones (mirroring requirements in dataclass and function arguments).	chipx86	10 months, 2 weeks ago
Can these be private?	chipx86	10 months, 2 weeks ago
We might as well make these async () => ... while we're at it.	chipx86	10 months, 2 weeks ago
There are no open issues

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/reviews/utils/diffFragmentQueue.ts (Diff revision 1)

The issue has been resolved. Show all issues

We usually have the optional attributes below the required ones (mirroring requirements in dataclass and function arguments).

reviewboard/static/rb/js/reviews/views/diffFragmentView.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Can these be private?
```
reviewboard/static/rb/js/reviews/views/tests/diffFragmentViewTests.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
We might as well make these async () => ... while we're at it.
```

Commits:

	Summary	ID
	Convert RB.DiffFragmentView to TypeScript/spina. This change converts RB.DiffFragmentView to TypeScript. Testing Done: - Ran js-tests. - Tested diff fragment loading in various situations.	b016ea43b03f1e3211731353f2b42c928f76654e
	Convert RB.DiffFragmentView to TypeScript/spina. This change converts RB.DiffFragmentView to TypeScript. Testing Done: - Ran js-tests. - Tested diff fragment loading in various situations.	9a0cddd3c403b9979a78da383c1add5c341b3272

Diff:

Revision 2 (+526 -358)

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/reviews/index.ts
	reviewboard/static/rb/js/reviews/utils/diffFragmentQueue.ts
	reviewboard/static/rb/js/reviews/utils/tests/diffFragmentQueueTests.ts
	reviewboard/static/rb/js/views/diffFragmentView.es6.js
	reviewboard/static/rb/js/views/tests/diffFragmentViewTests.es6.js
	reviewboard/static/rb/js/reviews/views/tests/index.ts

flake8 passed.

JSHint passed.

Ship it!