Summary

Convert RB.OAuthClientSecretView to TypeScript/spina

Review Request #14095 — Created Aug. 9, 2024 and submitted Sept. 6, 2024, 7:44 a.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change converts the OAauth client secret widget JS to TypeScript
and spina. I decided to merge this into the "widgets" bundle, since it
seemed excessive to have a separate bundle just for this one file.

Testing Done


Ran js-tests.
Verified that the OAuth secret input still worked as expected.

Commits

Summary	ID
Convert RB.OAuthClientSecretView to TypeScript/spina This change converts the OAauth client secret widget JS to TypeScript and spina. I decided to merge this into the "widgets" bundle, since it seemed excessive to have a separate bundle just for this one file. Testing Done: - Ran js-tests. - Verified that the OAuth secret input still worked as expected.	20a2ab14fd186f213b6f01bc60b32d8b0d601be5

Issues

Description	From	Last Updated
This should be protected.	chipx86	Aug. 12, 2024, 9:57 a.m.
This should maybe be private, and same with the other handler.	chipx86	Aug. 12, 2024, 9:57 a.m.

flake8 passed.

JSHint passed.

Ship it!

reviewboard/static/rb/js/widgets/views/oauthClientSecretView.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
This should be protected.
```
reviewboard/static/rb/js/widgets/views/oauthClientSecretView.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
This should maybe be private, and same with the other handler.
```

Status:: Completed
Change Summary:: Pushed to master (4f425ce)