Summary

Convert RB.JoinedGroupsView to TypeScript/spina

Review Request #14089 — Created Aug. 8, 2024 and submitted Sept. 6, 2024, 7:42 a.m.

Owner

Repository

Review Board

Branch

master

Bugs

Depends On

Groups

People

Description

This change converts the groups page for the account settings to
TypeScript.

Testing Done


Used the various features of the groups page.
Ran js-tests.

Commits

Summary	ID
Convert RB.JoinedGroupsView to TypeScript/spina This change converts the groups page for the account settings to TypeScript. Testing Done: - Used the various features of the groups page. - Ran js-tests.	625390580eeeb67c9fbd1d367d0f71c68052362f

Issues

Description	From	Last Updated
This doesn't pass in options as apply() would.	chipx86	Aug. 12, 2024, 9:49 a.m.
Maybe make this a template literal while here?	chipx86	Aug. 12, 2024, 9:50 a.m.
Let's sort these alphabetically.	chipx86	Aug. 12, 2024, 9:50 a.m.
Let's sort these alphabetically.	chipx86	Aug. 12, 2024, 9:50 a.m.

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/accountPrefsPage/views/joinedGroupsView.ts (Diff revision 1)
The issue has been dropped. Show all issues
```
This doesn't pass in options as apply() would.
```
1. david Aug. 12, 2024, 9:50 a.m.
  Parent class doesn't take/use options.
reviewboard/static/rb/js/accountPrefsPage/views/joinedGroupsView.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Maybe make this a template literal while here?
```

reviewboard/static/rb/js/accountPrefsPage/views/joinedGroupsView.ts (Diff revision 1)

The issue has been resolved. Show all issues

Let's sort these alphabetically.

reviewboard/static/rb/js/accountPrefsPage/views/joinedGroupsView.ts (Diff revision 1)

The issue has been resolved. Show all issues

Let's sort these alphabetically.

Commits:

	Summary	ID
	Convert RB.JoinedGroupsView to TypeScript/spina This change converts the groups page for the account settings to TypeScript. Testing Done: - Used the various features of the groups page. - Ran js-tests.	a290d029ab5d7f99d7339910d2ec6cbdc71cfc23
	Convert RB.JoinedGroupsView to TypeScript/spina This change converts the groups page for the account settings to TypeScript. Testing Done: - Used the various features of the groups page. - Ran js-tests.	625390580eeeb67c9fbd1d367d0f71c68052362f

Diff:

Revision 2 (+408 -210)

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/accountPrefsPage/index.ts
	reviewboard/static/rb/js/accountPrefsPage/views/joinedGroupsView.es6.js

flake8 passed.

JSHint passed.

Ship it!