Convert ClientLoginView to TypeScript/spina and make it a PageView.

Review Request #14088 — Created Aug. 8, 2024 and submitted — Latest diff uploaded

Information

Review Board
master

Reviewers

This change converts the ClientLoginView to TypeScript, and updates it
to inherit from PageView. This allows us to use our standard page view
options from the template instead of instantiating the view separately.

  • Ran js-tests.
  • Used rbtools' web-based login feature to log in and saw that
    everything in the flow worked correctly.

Diff Revision 2 (Latest)

orig
1
2

Commits

First Last Summary ID Author
Convert ClientLoginView to TypeScript/spina and make it a PageView.
This change converts the ClientLoginView to TypeScript, and updates it to inherit from PageView. This allows us to use our standard page view options from the template instead of instantiating the view separately. Testing Done: - Ran js-tests. - Used rbtools' web-based login feature to log in and saw that everything in the flow worked correctly.
5c9bbb2a5622a8c58bccef25b416d5533fb92919 David Trowbridge
reviewboard/staticbundles.py
reviewboard/static/rb/js/common/index.ts
reviewboard/static/rb/js/common/views/clientLoginPageView.ts
reviewboard/static/rb/js/common/views/tests/clientLoginViewTests.ts
reviewboard/static/rb/js/common/views/tests/index.ts
reviewboard/static/rb/js/views/clientLoginView.es6.js
reviewboard/static/rb/js/views/tests/clientLoginViewTests.es6.js
reviewboard/templates/accounts/client_login.html
Loading...