Summary

Convert ClientLoginView to TypeScript/spina and make it a PageView.

Review Request #14088 — Created Aug. 8, 2024 and submitted Sept. 2, 2024, 10:40 a.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Testing Done


Ran js-tests.
Used rbtools' web-based login feature to log in and saw that

  everything in the flow worked correctly.

Commits

Summary	ID
Convert ClientLoginView to TypeScript/spina and make it a PageView. This change converts the ClientLoginView to TypeScript, and updates it to inherit from PageView. This allows us to use our standard page view options from the template instead of instantiating the view separately. Testing Done: - Ran js-tests. - Used rbtools' web-based login feature to log in and saw that everything in the flow worked correctly.	5c9bbb2a5622a8c58bccef25b416d5533fb92919

Summary

Convert ClientLoginView to TypeScript/spina and make it a PageView.

This change converts the ClientLoginView to TypeScript, and updates it to inherit from PageView. This allows us to use our standard page view options from the template instead of instantiating the view separately. Testing Done: - Ran js-tests. - Used rbtools' web-based login feature to log in and saw that everything in the flow worked correctly.

5c9bbb2a5622a8c58bccef25b416d5533fb92919

Issues

Description	From	Last Updated
One-line summary. Same below.	chipx86	Aug. 12, 2024, 9:46 a.m.
This is in the inverse order. Newer changes are listed first.	chipx86	Aug. 12, 2024, 9:46 a.m.
These endblocks should reference the block name.	chipx86	Aug. 12, 2024, 9:47 a.m.
There's an extra "to" before the "from".	maubin	Aug. 13, 2024, 8:13 a.m.

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/common/views/clientLoginPageView.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
One-line summary.
Same below.
```

reviewboard/static/rb/js/common/views/clientLoginPageView.ts (Diff revision 1)

The issue has been resolved. Show all issues

This is in the inverse order. Newer changes are listed first.

reviewboard/templates/accounts/client_login.html (Diff revision 1)

The issue has been resolved. Show all issues

These endblocks should reference the block name.

Commits:

	Summary	ID
	Convert ClientLoginView to TypeScript/spina and make it a PageView. This change converts the ClientLoginView to TypeScript, and updates it to inherit from PageView. This allows us to use our standard page view options from the template instead of instantiating the view separately. Testing Done: - Ran js-tests. - Used rbtools' web-based login feature to log in and saw that everything in the flow worked correctly.	87131decabfb9e7896abfa1e2fff951677ed4bf9
	Convert ClientLoginView to TypeScript/spina and make it a PageView. This change converts the ClientLoginView to TypeScript, and updates it to inherit from PageView. This allows us to use our standard page view options from the template instead of instantiating the view separately. Testing Done: - Ran js-tests. - Used rbtools' web-based login feature to log in and saw that everything in the flow worked correctly.	5c9bbb2a5622a8c58bccef25b416d5533fb92919

Diff:

Revision 2 (+788 -572)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/common/index.ts
	reviewboard/static/rb/js/common/views/clientLoginPageView.ts
	reviewboard/static/rb/js/common/views/tests/clientLoginViewTests.ts
	reviewboard/static/rb/js/common/views/tests/index.ts
	reviewboard/static/rb/js/views/clientLoginView.es6.js
	reviewboard/static/rb/js/views/tests/clientLoginViewTests.es6.js
	reviewboard/templates/accounts/client_login.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

reviewboard/static/rb/js/common/views/clientLoginPageView.ts (Diff revision 2)
The issue has been resolved. Show all issues
```
There's an extra "to" before the "from".
```

Status:: Completed
Change Summary:: Pushed to master (a9d596e)