Fix up a handful of review-request related type problems.
Review Request #14087 — Created Aug. 8, 2024 and submitted — Latest diff uploaded
This change fixes up some issues with our typing and some issues exposed
by adding typing:
- In our review request data templates, the initial value of the
submitter
link was being added to the review request, but it really
only belongs on the review request draft. - Added the url field to the review group resource data definition.
- The types for several things inside the review request attributes were
incorrect (should have been ResourceLink[] instead of string[] or
ReviewRequest[]). - Types throughout the review request fields implementation had some
errors, especially typing for methods.
Ran js-tests.
reviewboard/reviews/templatetags/reviewtags.py |
---|
reviewboard/static/rb/js/common/resources/models/reviewGroupModel.ts |
---|
reviewboard/static/rb/js/common/resources/models/reviewRequestModel.ts |
---|
reviewboard/static/rb/js/reviews/views/reviewRequestFieldViews.ts |
---|