• 
      

    Fix up a handful of review-request related type problems.

    Review Request #14087 — Created Aug. 8, 2024 and submitted

    Information

    Review Board
    master

    Reviewers

    This change fixes up some issues with our typing and some issues exposed
    by adding typing:

    • In our review request data templates, the initial value of the
      submitter link was being added to the review request, but it really
      only belongs on the review request draft.
    • Added the url field to the review group resource data definition.
    • The types for several things inside the review request attributes were
      incorrect (should have been ResourceLink[] instead of string[] or
      ReviewRequest[]).
    • Types throughout the review request fields implementation had some
      errors, especially typing for methods.

    Ran js-tests.

    Summary ID
    Fix up a handful of review-request related type problems.
    This change fixes up some issues with our typing and some issues exposed by adding typing: - In our review request data templates, the initial value of the `submitter` link was being added to the review request, but it really only belongs on the review request draft. - Added the url field to the review group resource data definition. - The types for several things inside the review request attributes were incorrect (should have been ResourceLink[] instead of string[] or ReviewRequest[]). - Types throughout the review request fields implementation had some errors, especially typing for methods. Testing Done: Ran js-tests.
    11d3edd8a8d1b164f9446866771c55dfd855f42e
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (1540a41)