Convert RB.DraftReviewRequest to TypeScript/spina

 






 

 


  Review Request #14086
  —
  Created Aug. 8, 2024 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This change converts the DraftReviewRequest resource model to

TypeScript.


The one complication in here is a change in behavior with mixins

where the url() implementation in DraftResourceModelMixin was

taking priority over the one in DraftReviewRequest. In the vast

majority of draft resource cases, the implementation in the mixin

is what we want, but review requests are special.

 








  


 
 

  
    

  • Ran js-tests.
    • 

  • Ran setup.py build_media.
    • 


 







 









 





  








 




 







   

    
    
Diff Revision 2 (Latest)



    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Convert RB.DraftReviewRequest to TypeScript/spina
     
This change converts the DraftReviewRequest resource model to
TypeScript.

The one complication in here is a change in behavior with mixins
where the `url()` implementation in `DraftResourceModelMixin` was
taking priority over the one in `DraftReviewRequest`. In the vast
majority of draft resource cases, the implementation in the mixin
is what we want, but review requests are special.

Testing Done:
- Ran js-tests.
- Ran setup.py build_media.

    

   
  		
  b63ab99d9059a8055f2cb4b8bab318a5d1bfd253
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/staticbundles.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/common/resources/index.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/common/resources/models/draftResourceModelMixin.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/common/resources/models/draftReviewRequestModel.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/common/resources/models/reviewRequestModel.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/common/resources/models/userModel.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/resources/models/tests/draftReviewRequestModelTests.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/common/resources/models/tests/index.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/resources/models/draftReviewRequestModel.es6.js
     
    

   
  

 










     

    

   

  

  

   
   Loading...