Summary

Convert RB.DraftReviewRequest to TypeScript/spina

Review Request #14086 — Created Aug. 8, 2024 and submitted Sept. 6, 2024, 7:42 a.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change converts the DraftReviewRequest resource model to
TypeScript.

The one complication in here is a change in behavior with mixins
where the url() implementation in DraftResourceModelMixin was
taking priority over the one in DraftReviewRequest. In the vast
majority of draft resource cases, the implementation in the mixin
is what we want, but review requests are special.

Testing Done


Ran js-tests.
Ran setup.py build_media.

Commits

Summary	ID
Convert RB.DraftReviewRequest to TypeScript/spina This change converts the DraftReviewRequest resource model to TypeScript. The one complication in here is a change in behavior with mixins where the `url()` implementation in `DraftResourceModelMixin` was taking priority over the one in `DraftReviewRequest`. In the vast majority of draft resource cases, the implementation in the mixin is what we want, but review requests are special. Testing Done: - Ran js-tests. - Ran setup.py build_media.	b63ab99d9059a8055f2cb4b8bab318a5d1bfd253

Summary

Convert RB.DraftReviewRequest to TypeScript/spina

This change converts the DraftReviewRequest resource model to TypeScript. The one complication in here is a change in behavior with mixins where the `url()` implementation in `DraftResourceModelMixin` was taking priority over the one in `DraftReviewRequest`. In the vast majority of draft resource cases, the implementation in the mixin is what we want, but review requests are special. Testing Done: - Ran js-tests. - Ran setup.py build_media.

b63ab99d9059a8055f2cb4b8bab318a5d1bfd253

Issues

Description	From	Last Updated
This change isn't documented in the description. What's it for?	chipx86	Aug. 12, 2024, 9:42 a.m.
Should we Version Added this one?	chipx86	Aug. 12, 2024, 9:42 a.m.

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/common/resources/models/draftResourceModelMixin.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
This change isn't documented in the description. What's it for?
```
1. david Aug. 12, 2024, 9:42 a.m.
  Added to the description and made a note in this method's doc comment too.

reviewboard/static/rb/js/common/resources/models/userModel.ts (Diff revision 1)

The issue has been resolved. Show all issues

Should we Version Added this one?

Description:

		This change converts the DraftReviewRequest resource model to
		TypeScript.
	+
	+	The one complication in here is a change in behavior with mixins
	+	where the `url()` implementation in `DraftResourceModelMixin` was
	+	taking priority over the one in `DraftReviewRequest`. In the vast
	+	majority of draft resource cases, the implementation in the mixin
	+	is what we want, but review requests are special.

Commits:

	Summary	ID
	Convert RB.DraftReviewRequest to TypeScript/spina This change converts the DraftReviewRequest resource model to TypeScript. Testing Done: - Ran js-tests. - Ran setup.py build_media.	660a7b38c1ea345a213178245b96b21c9bb952ee
	Convert RB.DraftReviewRequest to TypeScript/spina This change converts the DraftReviewRequest resource model to TypeScript. The one complication in here is a change in behavior with mixins where the `url()` implementation in `DraftResourceModelMixin` was taking priority over the one in `DraftReviewRequest`. In the vast majority of draft resource cases, the implementation in the mixin is what we want, but review requests are special. Testing Done: - Ran js-tests. - Ran setup.py build_media.	b63ab99d9059a8055f2cb4b8bab318a5d1bfd253

Diff:

Revision 2 (+728 -332)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/common/resources/index.ts
	reviewboard/static/rb/js/common/resources/models/draftResourceModelMixin.ts
	reviewboard/static/rb/js/common/resources/models/draftReviewRequestModel.ts
	reviewboard/static/rb/js/common/resources/models/reviewRequestModel.ts
	reviewboard/static/rb/js/common/resources/models/userModel.ts
	reviewboard/static/rb/js/resources/models/tests/draftReviewRequestModelTests.es6.js
	reviewboard/static/rb/js/common/resources/models/tests/index.ts
	1 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (f295cee)