Summary

Convert RB.ValidateDiffModel to TypeScript/spina.

Review Request #14085 — Created Aug. 8, 2024 and submitted Sept. 6, 2024, 7:42 a.m.

Owner

Repository

Review Board

Branch

master

Bugs

Depends On

Groups

People

Description

This change converts the ValidateDiffModel resource model to TypeScript.

Testing Done


Ran js-tests.
Ran setup.py build_media.

Commits

Summary	ID
Convert RB.ValidateDiffModel to TypeScript/spina. This change converts the ValidateDiffModel resource model to TypeScript. Testing Done: - Ran js-tests. - Ran setup.py build_media.	90f7a754393b4d4f6ad312c6d7b581de11f499c4

Issues

Description	From	Last Updated
This is missing Args and Returns.	chipx86	Aug. 12, 2024, 9:08 a.m.
This can be model.getURL() now.	chipx86	Aug. 12, 2024, 9:09 a.m.

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/common/resources/models/validateDiffModel.ts (Diff revision 1)

The issue has been resolved. Show all issues

This is missing Args and Returns.

reviewboard/static/rb/js/common/resources/models/tests/validateDiffModelTests.ts (Diff revision 1)

The issue has been resolved. Show all issues

This can be model.getURL() now.

Commits:

	Summary	ID
	Convert RB.ValidateDiffModel to TypeScript/spina. This change coverts the ValidateDiffModel resource model to TypeScript. Testing Done: - Ran js-tests.	c8327672665b6ed423be92f963521b24190dfde0
	Convert RB.ValidateDiffModel to TypeScript/spina. This change converts the ValidateDiffModel resource model to TypeScript. Testing Done: - Ran js-tests. - Ran setup.py build_media.	90f7a754393b4d4f6ad312c6d7b581de11f499c4

Diff:

Revision 2 (+254 -106)

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/common/resources/index.ts
	reviewboard/static/rb/js/common/resources/models/diffModel.ts
	reviewboard/static/rb/js/common/resources/models/validateDiffModel.ts
	reviewboard/static/rb/js/common/resources/models/tests/index.ts
	reviewboard/static/rb/js/resources/models/tests/validateDiffModelTests.es6.js
	reviewboard/static/rb/js/resources/models/validateDiffModel.es6.js

flake8 passed.

JSHint passed.

Ship it!