Summary

Convert repository branch and commit models/collections to TypeScript/spina.

Review Request #14083 — Created Aug. 8, 2024 and submitted Sept. 6, 2024, 7:42 a.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change converts the RB.RepositoryBranch and RB.RepositoryCommit
resource models to TypeScript, along with the RB.RepositoryBranches and
RB.RepositoryCommits collections.

Testing Done


Ran js-tests.
Ran setup.py build_media.

Commits

Summary	ID
Convert repository branch and commit models/collections to TypeScript/spina. This change converts the RB.RepositoryBranch and RB.RepositoryCommit resource models to TypeScript, along with the RB.RepositoryBranches and RB.RepositoryCommits collections. Testing Done: - Ran js-tests. - Ran setup.py build_media.	cad6c6342fc2ca2b37ba8fd65d5493c668ee67b1

Issues

Description	From	Last Updated
Must be a single-line summary.	chipx86	Aug. 12, 2024, 9:04 a.m.
We should probably list these alphabetically.	chipx86	Aug. 12, 2024, 9:04 a.m.
Missing space before the =.	chipx86	Aug. 12, 2024, 9:04 a.m.
This can be Record<string, string>.	chipx86	Aug. 12, 2024, 9:05 a.m.
We should probably type these, if we can.	chipx86	Aug. 12, 2024, 9:06 a.m.

flake8 passed.

JSHint passed.

Commits:

	Summary	ID
	Convert repository branch and commit models/collections to TypeScript/spina. This change converts the RB.RepositoryBranch and RB.RepositoryCommit resource models to TypeScript, along with the RB.RepositoryBranches and RB.RepositoryCommits collections. Testing Done: - Ran js-tests. - Ran setup.py build_media.	5fabdca6600280b4baa77d9ec970a46b3daab472
	Convert repository branch and commit models/collections to TypeScript/spina. This change converts the RB.RepositoryBranch and RB.RepositoryCommit resource models to TypeScript, along with the RB.RepositoryBranches and RB.RepositoryCommits collections. Testing Done: - Ran js-tests. - Ran setup.py build_media.	8b4faf10ee1aecc42c470b2ced542176902cfb0e

Diff:

Revision 2 (+842 -464)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/common/resources/index.ts
	reviewboard/static/rb/js/common/resources/collections/repositoryBranchesCollection.ts
	reviewboard/static/rb/js/resources/collections/repositoryCommitsCollection.es6.js
	reviewboard/static/rb/js/common/resources/collections/tests/index.ts
	reviewboard/static/rb/js/resources/collections/tests/repositoryBranchesCollectionTests.es6.js
	reviewboard/static/rb/js/resources/collections/tests/repositoryCommitsCollectionTests.es6.js
	reviewboard/static/rb/js/common/resources/models/repositoryBranchModel.ts
	7 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commits:

	Summary	ID
	Convert repository branch and commit models/collections to TypeScript/spina. This change converts the RB.RepositoryBranch and RB.RepositoryCommit resource models to TypeScript, along with the RB.RepositoryBranches and RB.RepositoryCommits collections. Testing Done: - Ran js-tests. - Ran setup.py build_media.	8b4faf10ee1aecc42c470b2ced542176902cfb0e
	Convert repository branch and commit models/collections to TypeScript/spina. This change converts the RB.RepositoryBranch and RB.RepositoryCommit resource models to TypeScript, along with the RB.RepositoryBranches and RB.RepositoryCommits collections. Testing Done: - Ran js-tests. - Ran setup.py build_media.	4bb603825122b7336daabb25d6672f6ed58c8d84

Diff:

Revision 3 (+878 -514)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/common/resources/index.ts
	reviewboard/static/rb/js/common/resources/collections/repositoryBranchesCollection.ts
	reviewboard/static/rb/js/resources/collections/repositoryCommitsCollection.es6.js
	reviewboard/static/rb/js/common/resources/collections/tests/index.ts
	reviewboard/static/rb/js/resources/collections/tests/repositoryBranchesCollectionTests.es6.js
	reviewboard/static/rb/js/resources/collections/tests/repositoryCommitsCollectionTests.es6.js
	reviewboard/static/rb/js/common/resources/models/repositoryBranchModel.ts
	8 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/common/resources/models/repositoryBranchModel.ts (Diff revision 3)

The issue has been resolved. Show all issues

Must be a single-line summary.

reviewboard/static/rb/js/common/resources/models/repositoryBranchModel.ts (Diff revision 3)

The issue has been resolved. Show all issues

We should probably list these alphabetically.

reviewboard/static/rb/js/common/resources/collections/repositoryCommitsCollection.ts (Diff revision 3)

The issue has been resolved. Show all issues

Missing space before the =.

reviewboard/static/rb/js/common/resources/collections/repositoryCommitsCollection.ts (Diff revision 3)

The issue has been resolved. Show all issues

This can be Record<string, string>.

reviewboard/static/rb/js/common/resources/collections/repositoryCommitsCollection.ts (Diff revision 3)

The issue has been dropped. Show all issues

We should probably type these, if we can.

david Aug. 12, 2024, 9:06 a.m.

I'm going to be removing these deprecated callbacks in a later change, at which point this method won't take any args.

Commits:

	Summary	ID
	Convert repository branch and commit models/collections to TypeScript/spina. This change converts the RB.RepositoryBranch and RB.RepositoryCommit resource models to TypeScript, along with the RB.RepositoryBranches and RB.RepositoryCommits collections. Testing Done: - Ran js-tests. - Ran setup.py build_media.	4bb603825122b7336daabb25d6672f6ed58c8d84
	Convert repository branch and commit models/collections to TypeScript/spina. This change converts the RB.RepositoryBranch and RB.RepositoryCommit resource models to TypeScript, along with the RB.RepositoryBranches and RB.RepositoryCommits collections. Testing Done: - Ran js-tests. - Ran setup.py build_media.	cad6c6342fc2ca2b37ba8fd65d5493c668ee67b1

Diff:

Revision 4 (+884 -514)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/common/resources/index.ts
	reviewboard/static/rb/js/common/resources/collections/repositoryBranchesCollection.ts
	reviewboard/static/rb/js/resources/collections/repositoryCommitsCollection.es6.js
	reviewboard/static/rb/js/common/resources/collections/tests/index.ts
	reviewboard/static/rb/js/resources/collections/tests/repositoryBranchesCollectionTests.es6.js
	reviewboard/static/rb/js/resources/collections/tests/repositoryCommitsCollectionTests.es6.js
	reviewboard/static/rb/js/common/resources/models/repositoryBranchModel.ts
	8 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (d8048fb)