Summary

Convert RB.APITokensView to TypeScript/spina.

Review Request #14077 — Created Aug. 6, 2024 and submitted Aug. 19, 2024, 9:20 a.m.

Owner

Repository

Review Board

Branch

master

Bugs

Depends On

Groups

People

Description

This change converts the API tokens view to TypeScript.

Testing Done


Ran js-tests.
Ran setup.py build_media.
Added, edited, copied, and removed API tokens.

Commits

Summary	ID
Convert RB.APITokensView to TypeScript/spina. This change converts the API tokens view to TypeScript. Testing Done: - Ran js-tests. - Ran setup.py build_media. - Added, edited, copied, and removed API tokens.	2c81fc8aaec29a27586daef63ab7954b050efe22

Issues

Description	From	Last Updated
These are missing docs.	chipx86	Aug. 12, 2024, 8:52 a.m.
This is missing docs.	chipx86	Aug. 12, 2024, 8:52 a.m.
This regresses any options going in.	chipx86	Aug. 12, 2024, 8:52 a.m.
Can you add Returns while here?	chipx86	Aug. 12, 2024, 8:53 a.m.
Can we standardize on T or T-based naming?	chipx86	Aug. 12, 2024, 8:53 a.m.
This is missing docs.	chipx86	Aug. 12, 2024, 8:54 a.m.
Must be a one-line summary.	chipx86	Aug. 12, 2024, 8:54 a.m.
This should be using as syntax, as <...>var syntax is deprecated.	chipx86	Aug. 12, 2024, 8:55 a.m.
Left-over debug output.	chipx86	Aug. 12, 2024, 8:55 a.m.
We should continue to pass all arguments down the chain.	chipx86	Aug. 12, 2024, 8:57 a.m.

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/accountPrefsPage/views/apiTokensView.ts (Diff revision 1)

The issue has been resolved. Show all issues

These are missing docs.

reviewboard/static/rb/js/accountPrefsPage/views/apiTokensView.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
This is missing docs.
```
reviewboard/static/rb/js/accountPrefsPage/views/apiTokensView.ts (Diff revision 1)
The issue has been dropped. Show all issues
```
This regresses any options going in.
```
1. david Aug. 12, 2024, 8:58 a.m.
  The base class doesn't take/use options.

reviewboard/static/rb/js/accountPrefsPage/views/apiTokensView.ts (Diff revision 1)

The issue has been resolved. Show all issues

Can you add Returns while here?

reviewboard/static/rb/js/accountPrefsPage/views/apiTokensView.ts (Diff revision 1)

The issue has been resolved. Show all issues

Can we standardize on T or T-based naming?

reviewboard/static/rb/js/accountPrefsPage/views/apiTokensView.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
This is missing docs.
```
reviewboard/static/rb/js/accountPrefsPage/views/apiTokensView.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Must be a one-line summary.
```
reviewboard/static/rb/js/accountPrefsPage/views/apiTokensView.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
This should be using as syntax, as <...>var syntax is deprecated.
```
reviewboard/static/rb/js/accountPrefsPage/views/apiTokensView.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Left-over debug output.
```
reviewboard/static/rb/js/accountPrefsPage/views/apiTokensView.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
We should continue to pass all arguments down the chain.
```
1. david Aug. 12, 2024, 8:58 a.m.
  Turns out we don't have any initialize methods in any of the parents.

Commits:

	Summary	ID
	Convert RB.APITokensView to TypeScript/spina. This change converts the API tokens view to TypeScript. Testing Done: - Ran js-tests. - Ran setup.py build_media. - Added, edited, copied, and removed API tokens.	9d0611bbe3f54f382ecec89aac0127a11781ee20
	Convert RB.APITokensView to TypeScript/spina. This change converts the API tokens view to TypeScript. Testing Done: - Ran js-tests. - Ran setup.py build_media. - Added, edited, copied, and removed API tokens.	2c81fc8aaec29a27586daef63ab7954b050efe22

Diff:

Revision 2 (+940 -556)

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/accountPrefsPage/index.ts
	reviewboard/static/rb/js/accountPrefsPage/views/apiTokensView.es6.js

flake8 passed.

JSHint passed.

Ship it!