This change has been marked as completed.

Describe the completed change (optional):

Pushed to master (49a65d9)

Summary

Convert RB.Config.ResourceListItemModel to TypeScript/spina.

Review Request #14076 — Created Aug. 4, 2024 and submitted 8 months, 2 weeks ago

Owner

Repository

Review Board

Branch

master

Bugs

Depends On

Groups

People

Description*

This change converts the ResourceListItemModel to TypeScript.

Testing Done


Ran js-tests.
Ran setup.py build_media.

Commits

Summary	ID
Convert RB.Config.ResourceListItemModel to TypeScript/spina. This change converts the ResourceListItemModel to TypeScript. Testing Done: - Ran js-tests. - Ran setup.py build_media.	b9d4aafadbc69d2e34c3d4a127bae09c700ef37e

Issues

Description	From	Last Updated
This is a change in behavior, as initialize() also takes options.	chipx86	8 months, 3 weeks ago
Can you add Args and Returns while here?	chipx86	8 months, 3 weeks ago
There are no open issues

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/configForms/models/resourceListItemModel.ts (Diff revision 1)

The issue has been dropped. Show all issues

This is a change in behavior, as initialize() also takes options.

Not actually, since ConfigFormsListItem.initialize() doesn't take/use options.

reviewboard/static/rb/js/configForms/models/resourceListItemModel.ts (Diff revision 1)

The issue has been resolved. Show all issues

Can you add Args and Returns while here?

Commits:

	Summary	ID
	Convert RB.Config.ResourceListItemModel to TypeScript/spina. This change converts the ResourceListItemModel to TypeScript. Testing Done: - Ran js-tests. - Ran setup.py build_media.	3098bf4a741f89d69f0e2ee46ed69ade675d7612
	Convert RB.Config.ResourceListItemModel to TypeScript/spina. This change converts the ResourceListItemModel to TypeScript. Testing Done: - Ran js-tests. - Ran setup.py build_media.	b9d4aafadbc69d2e34c3d4a127bae09c700ef37e

Diff:

Revision 2 (+272 -60)

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/configForms/index.ts
	reviewboard/static/rb/js/configForms/models/resourceListItemModel.es6.js
	reviewboard/static/rb/js/configForms/models/tests/index.ts
	reviewboard/static/rb/js/configForms/models/tests/resourceListItemModelTests.es6.js
	reviewboard/static/rb/js/tests/index.ts

flake8 passed.

JSHint passed.

Ship it!