Summary

Convert comment reply models to TypeScript/spina.

Review Request #14075 — Created Aug. 4, 2024 and submitted Aug. 19, 2024, 9:21 a.m.

Owner

Repository

Review Board

Branch

master

Bugs

Depends On

Groups

People

Description

Convert comment reply models to TypeScript/spina.

Testing Done


Ran js-tests.
Ran setup.py build_media.

Commits

Summary	ID
Convert comment reply models to TypeScript/spina. This change converts all the comment reply resource models to TypeScript. Testing Done: - Ran js-tests. - Ran setup.py build_media.	34c918ad1e81bfc289390566ad9f82179bf7e55b

Issues

Description	From	Last Updated
Must be a single-line summary. Same below.	chipx86	Aug. 12, 2024, 8:35 a.m.
The comma should be a semicolon.	chipx86	Aug. 12, 2024, 8:35 a.m.

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/common/resources/models/baseCommentReplyModel.ts (Diff revision 1)

The issue has been resolved. Show all issues

Must be a single-line summary.

Same below.

reviewboard/static/rb/js/common/resources/models/baseCommentReplyModel.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
The comma should be a semicolon.
```

Commits:

	Summary	ID
	Convert comment reply models to TypeScript/spina. Testing Done: - Ran js-tests. - Ran setup.py build_media.	d4f5a529c2c1f2dd88a58b1a12ec96d2419931d8
	Convert comment reply models to TypeScript/spina. This change converts all the comment reply resource models to TypeScript. Testing Done: - Ran js-tests. - Ran setup.py build_media.	34c918ad1e81bfc289390566ad9f82179bf7e55b

Diff:

Revision 2 (+584 -352)

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/common/resources/index.ts
	reviewboard/static/rb/js/common/resources/models/baseCommentReplyModel.ts
	reviewboard/static/rb/js/common/resources/models/diffCommentReplyModel.ts
	reviewboard/static/rb/js/common/resources/models/fileAttachmentCommentReplyModel.ts
	reviewboard/static/rb/js/common/resources/models/generalCommentReplyModel.ts
	reviewboard/static/rb/js/common/resources/models/screenshotCommentReplyModel.ts
	reviewboard/static/rb/js/resources/models/tests/baseCommentReplyModelTests.es6.js
	6 more

flake8 passed.

JSHint passed.

Ship it!