Summary

Convert comment models to TypeScript/spina.

Review Request #14074 — Created Aug. 4, 2024 and submitted Aug. 19, 2024, 9:21 a.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

People

Description

This change converts all the comment resource models to TypeScript.

Testing Done


Ran js-tests.
Ran setup.py build_media.

Commits

Summary	ID
Convert comment models to TypeScript/spina. This change converts all the comment resource models to TypeScript. Testing Done: - Ran js-tests. - Ran setup.py build_media.	78e25b894ea0c05257384e31e0a21132b946451e

Issues

Description	From	Last Updated
We normally aim to keep entries alphabetized. It's a bit wonkier here since there are clear pairings. That'd be fine …	chipx86	Aug. 11, 2024, 3:29 p.m.
Must be a one-line summary.	chipx86	Aug. 11, 2024, 3:30 p.m.
Same here.	chipx86	Aug. 11, 2024, 3:30 p.m.
Same here.	chipx86	Aug. 11, 2024, 3:30 p.m.
This can be a Record<string, string>.	chipx86	Aug. 11, 2024, 3:30 p.m.
These all need one-line summaries.	chipx86	Aug. 11, 2024, 3:33 p.m.
In this case, we've been keeping extends unindented.	chipx86	Aug. 11, 2024, 3:33 p.m.
This can be Record<string, string>.	chipx86	Aug. 11, 2024, 3:33 p.m.
Should be a single line.	chipx86	Aug. 11, 2024, 3:34 p.m.
Same general note about alphabetical order of attributes. It's a trade-off.	chipx86	Aug. 11, 2024, 3:35 p.m.
Can be Record<string, string>.	chipx86	Aug. 11, 2024, 3:35 p.m.
This can be Record<string, FileAttachmentComment>.	chipx86	Aug. 11, 2024, 3:35 p.m.
I think this is a copy-paste-o.	maubin	Aug. 19, 2024, 9:06 a.m.

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/common/resources/models/diffCommentModel.ts (Diff revision 1)

The issue has been resolved. Show all issues

We normally aim to keep entries alphabetized. It's a bit wonkier here since there are clear pairings. That'd be fine except then it's less clear where other things go. Given that, I kind of feel like it's better just to keep them alphabetized.

reviewboard/static/rb/js/common/resources/models/diffCommentModel.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Must be a one-line summary.
```
reviewboard/static/rb/js/common/resources/models/diffCommentModel.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Same here.
```
reviewboard/static/rb/js/common/resources/models/diffCommentModel.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Same here.
```
reviewboard/static/rb/js/common/resources/models/diffCommentModel.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
This can be a Record<string, string>.
```

reviewboard/static/rb/js/common/resources/models/fileAttachmentCommentModel.ts (Diff revision 1)

The issue has been resolved. Show all issues

These all need one-line summaries.

reviewboard/static/rb/js/common/resources/models/fileAttachmentCommentModel.ts (Diff revision 1)

The issue has been resolved. Show all issues

In this case, we've been keeping extends unindented.

reviewboard/static/rb/js/common/resources/models/fileAttachmentCommentModel.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
This can be Record<string, string>.
```

reviewboard/static/rb/js/common/resources/models/generalCommentModel.ts (Diff revision 1)

The issue has been resolved. Show all issues

Should be a single line.

reviewboard/static/rb/js/common/resources/models/screenshotCommentModel.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Same general note about alphabetical order of attributes. It's a trade-off.
```
reviewboard/static/rb/js/common/resources/models/screenshotCommentModel.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Can be Record<string, string>.
```

reviewboard/static/rb/js/reviews/models/reviewRequestEditorModel.ts (Diff revision 1)

The issue has been resolved. Show all issues

This can be Record<string, FileAttachmentComment>.

Commits:

	Summary	ID
	Convert comment models to TypeScript/spina. This change converts all the comment resource models to TypeScript. Testing Done: - Ran js-tests. - Ran setup.py build_media.	0663462b3e80919c4440ef715395af14f3ac94ea
	Convert comment models to TypeScript/spina. This change converts all the comment resource models to TypeScript. Testing Done: - Ran js-tests. - Ran setup.py build_media.	78e25b894ea0c05257384e31e0a21132b946451e

Diff:

Revision 2 (+1778 -1210)

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/common/resources/index.ts
	reviewboard/static/rb/js/common/resources/models/baseCommentModel.ts
	reviewboard/static/rb/js/common/resources/models/diffCommentModel.ts
	reviewboard/static/rb/js/common/resources/models/fileAttachmentCommentModel.ts
	reviewboard/static/rb/js/common/resources/models/generalCommentModel.ts
	reviewboard/static/rb/js/common/resources/models/reviewModel.ts
	reviewboard/static/rb/js/common/resources/models/screenshotCommentModel.ts
	19 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

reviewboard/static/rb/js/common/resources/models/diffCommentModel.ts (Diff revision 2)
The issue has been dropped. Show all issues
```
I think this is a copy-paste-o.
```

Status:: Completed
Change Summary:: Pushed to master (f44e4ce), master (d145e0a)