Convert comment models to TypeScript/spina.

 






 

 


  Review Request #14074
  —
  Created Aug. 4, 2024 and submitted 

 




















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This change converts all the comment resource models to TypeScript.

 








  


 
 

  
    

  • Ran js-tests.
    • 

  • Ran setup.py build_media.
    • 


 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     

      Convert comment models to TypeScript/spina.
      
This change converts all the comment resource models to TypeScript.

Testing Done:
- Ran js-tests.
- Ran setup.py build_media.

     


    		
    78e25b894ea0c05257384e31e0a21132b946451e

   



  
 




 













 






 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
We normally aim to keep entries alphabetized. It's a bit wonkier here since there are clear pairings. That'd be fine …

      		
      
       chipx86chipx86
      
      
       
      
     




     

      
       
       
Must be a one-line summary.

      		
      
       chipx86chipx86
      
      
       
      
     




     

      
       
       
Same here.

      		
      
       chipx86chipx86
      
      
       
      
     




     

      
       
       
Same here.

      		
      
       chipx86chipx86
      
      
       
      
     




     

      
       
       
This can be a Record<string, string>.

      		
      
       chipx86chipx86
      
      
       
      
     




     

      
       
       
These all need one-line summaries.

      		
      
       chipx86chipx86
      
      
       
      
     




     

      
       
       
In this case, we've been keeping extends unindented.

      		
      
       chipx86chipx86
      
      
       
      
     




     

      
       
       
This can be Record<string, string>.

      		
      
       chipx86chipx86
      
      
       
      
     




     

      
       
       
Should be a single line.

      		
      
       chipx86chipx86
      
      
       
      
     




     

      
       
       
Same general note about alphabetical order of attributes. It's a trade-off.

      		
      
       chipx86chipx86
      
      
       
      
     




     

      
       
       
Can be Record<string, string>.

      		
      
       chipx86chipx86
      
      
       
      
     




     

      
       
       
This can be Record<string, FileAttachmentComment>.

      		
      
       chipx86chipx86
      
      
       
      
     




     

      
       
       
I think this is a copy-paste-o.

      		
      
       maubinmaubin
      
      
       
      
     


    

 There are no open issues


   

  

 







 






  

 



















 




 




 














 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86



    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       reviewboard/static/rb/js/common/resources/models/diffCommentModel.ts
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  
  
   Show all issues
  
 
    

    



    
    We normally aim to keep entries alphabetized. It's a bit wonkier here since there are clear pairings. That'd be fine except then it's less clear where other things go. Given that, I kind of feel like it's better just to keep them alphabetized.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 






  3. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       reviewboard/static/rb/js/common/resources/models/diffCommentModel.ts
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  
  
   Show all issues
  
 
    

    



    
    Must be a one-line summary.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 






  4. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       reviewboard/static/rb/js/common/resources/models/diffCommentModel.ts
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  
  
   Show all issues
  
 
    

    



    
    Same here.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    5. 






  5. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       reviewboard/static/rb/js/common/resources/models/diffCommentModel.ts
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  
  
   Show all issues
  
 
    

    



    
    Same here.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    6. 






  6. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       reviewboard/static/rb/js/common/resources/models/diffCommentModel.ts
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  
  
   Show all issues
  
 
    

    



    
    This can be a Record<string, string>.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    7. 






  7. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       reviewboard/static/rb/js/common/resources/models/fileAttachmentCommentModel.ts
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  
  
   Show all issues
  
 
    

    



    
    These all need one-line summaries.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    8. 






  8. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       reviewboard/static/rb/js/common/resources/models/fileAttachmentCommentModel.ts
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  
  
   Show all issues
  
 
    

    



    
    In this case, we've been keeping extends unindented.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    9. 






  9. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       reviewboard/static/rb/js/common/resources/models/fileAttachmentCommentModel.ts
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  
  
   Show all issues
  
 
    

    



    
    This can be Record<string, string>.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    10. 






  10. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       reviewboard/static/rb/js/common/resources/models/generalCommentModel.ts
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  
  
   Show all issues
  
 
    

    



    
    Should be a single line.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    11. 






  11. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       reviewboard/static/rb/js/common/resources/models/screenshotCommentModel.ts
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  
  
   Show all issues
  
 
    

    



    
    Same general note about alphabetical order of attributes. It's a trade-off.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    12. 






  12. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       reviewboard/static/rb/js/common/resources/models/screenshotCommentModel.ts
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  
  
   Show all issues
  
 
    

    



    
    Can be Record<string, string>.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    13. 






  13. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       reviewboard/static/rb/js/reviews/models/reviewRequestEditorModel.ts
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  
  
   Show all issues
  
 
    

    



    
    This can be Record<string, FileAttachmentComment>.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    14. 




  14. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    15. 




  

 
















 



 

  

   




david




   

   

  

 



 















 





 

  

   




maubin




   

   









  

 



 

  


   

   

    
 
maubin



    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       reviewboard/static/rb/js/common/resources/models/diffCommentModel.ts
       


        (Diff revision 2)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  
  
   Show all issues
  
 
    

    



    
    I think this is a copy-paste-o.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




david




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  







  

   

    Status:
   

   


    Completed

   

  




  

   

    Change Summary:
   

   

    
Pushed to master (f44e4ce), master (d145e0a)

   

  















  

 









     

    

   

  

  

   
   Loading...