This change has been marked as completed.

Describe the completed change (optional):

Pushed to master (5d7789d)

Summary

Port RB.DialogView to TypeScript/spina and deprecate.

Review Request #14072 — Created Aug. 4, 2024 and submitted 8 months ago — Latest diff uploaded 8 months ago

Owner

Repository

Review Board

Branch

master

Bugs

Depends On

Groups

People

Description*

This change ports the DialogView class to TypeScript, and also adds a

warning that it's now deprecated in favor of the new Dialog ink

component.

Testing Done


Ran js-tests.
Tested that the upload attachment view still worked (though this will

  be ported to Ink in a later change).

First	Last	Summary	ID	Author
		Port RB.DialogView to TypeScript/spina and deprecate. This change ports the DialogView class to TypeScript, and also adds a warning that it's now deprecated in favor of the new Dialog ink component. Testing Done: - Ran js-tests. - Tested that the upload attachment view still worked (though this will be ported to Ink in a later change).	903eec3f5e7bb64efd6f0b9785a4efaba86ddd10	David Trowbridge

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/ui/index.ts
	reviewboard/static/rb/js/ui/views/dialogView.ts Was reviewboard/static/rb/js/ui/views/dialogView.es6.js
	reviewboard/static/rb/js/ui/views/tests/dialogViewTests.ts Was reviewboard/static/rb/js/ui/views/tests/dialogViewTests.es6.js
	reviewboard/static/rb/js/ui/views/tests/index.ts

reviewboard/staticbundles.py

reviewboard/static/rb/js/ui/index.ts

reviewboard/static/rb/js/ui/views/dialogView.es6.js

reviewboard/static/rb/js/ui/views/tests/dialogViewTests.es6.js

reviewboard/static/rb/js/ui/views/tests/index.ts