Summary

Fix parsing of Mercurial git diffs that add binary files.

Review Request #14071 — Created Aug. 2, 2024 and submitted Aug. 5, 2024, 9:09 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

A previous fix had added overrides for binary files in Mercurial-
generated git diffs to fix up the commit IDs, because those
did not include an index line. Unfortunately, added binary files in
Mercurial git diffs do include an index line, and the override was
stomping on the PRE_CREATION orig version. This change fixes that up.

Testing Done

Ran unit tests. New test failed before the fix and succeeds after.

Commits

Summary	ID
Fix parsing of Mercurial git diffs that add binary files. A previous fix had added overrides for binary files in Mercurial- generated git diffs to fix up the commit IDs, because those did not include an index line. Unfortunately, added binary files in Mercurial git diffs do include an index line, and the override was stomping on the PRE_CREATION orig version. This change fixes that up. Testing Done: Ran unit tests. New test failed before the fix and succeeds after.	7e8d01d999fe37cfac73b57b28f40ec330b31799

Summary

Fix parsing of Mercurial git diffs that add binary files.

A previous fix had added overrides for binary files in Mercurial- generated git diffs to fix up the commit IDs, because those did not include an index line. Unfortunately, *added* binary files in Mercurial git diffs *do* include an index line, and the override was stomping on the PRE_CREATION orig version. This change fixes that up. Testing Done: Ran unit tests. New test failed before the fix and succeeds after.

7e8d01d999fe37cfac73b57b28f40ec330b31799

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.x (94938e0)