Fix file display for added + edited files across commits.

Review Request #14070 — Created Aug. 2, 2024 and submitted

Information

Review Board
release-7.x

Reviewers

When a file is added in one commit and then edited in another, we were
incorrectly showing that file as edited when viewing commit ranges. The
problem here was that we weren't propagating the new-file state through
when the ancestor list included adding the file.

  • Ran unit tests. Newly-added test failed before the fix and succeeds
    after.
  • Posted a change that involved a bunch of commits where some files were
    added in one commit and then changed in later ones. Saw that commit
    range diffs properly showed the file as added when the selected base
    commit was the commit which added the file or earlier.
Summary ID
Fix file display for added + edited files across commits.
When a file is added in one commit and then edited in another, we were incorrectly showing that file as edited when viewing commit ranges. The problem here was that we weren't propagating the new-file state through when the ancestor list included adding the file. Testing Done: - Ran unit tests. Newly-added test failed before the fix and succeeds after. - Posted a change that involved a bunch of commits where some files were added in one commit and then changed in later ones. Saw that commit range diffs properly showed the file as added when the selected base commit was the commit which added the file or earlier.
3ff67a0250e6d61c8d7636774e0e354430e3d1f8
chipx86
  1. Ship It!
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-7.x (a2d73be)