Fix access level of onInitialRender() and onRender() implementations.
Review Request #14067 — Created Aug. 2, 2024 and submitted — Latest diff uploaded
Many of the new spina-based classes weren't properly listing their
render methods as protected. While this didn't affect runtime at all, it
does trigger some TS warnings.
Ran js-tests.
Diff Revision 1 (Latest)
Commits
Files
| reviewboard/static/rb/js/common/views/pageView.ts |
|---|
| reviewboard/static/rb/js/reviewRequestPage/views/reviewReplyDraftBannerView.ts |
|---|
| reviewboard/static/rb/js/reviews/views/abstractReviewableView.ts |
|---|
| reviewboard/static/rb/js/reviews/views/commentDialogView.ts |
|---|
| reviewboard/static/rb/js/reviews/views/diffCommentsHintView.ts |
|---|
| reviewboard/static/rb/js/reviews/views/diffFileIndexView.ts |
|---|
| reviewboard/static/rb/js/reviews/views/diffReviewableView.ts |
|---|
| reviewboard/static/rb/js/reviews/views/fileAttachmentThumbnailView.ts |
|---|
| reviewboard/static/rb/js/reviews/views/imageReviewableView.ts |
|---|
| reviewboard/static/rb/js/reviews/views/reviewDialogView.ts |
|---|
| reviewboard/static/rb/js/reviews/views/reviewRequestActions.ts |
|---|
| reviewboard/static/rb/js/reviews/views/reviewRequestEditorView.ts |
|---|
| reviewboard/static/rb/js/reviews/views/reviewRequestFieldViews.ts |
|---|
| reviewboard/static/rb/js/reviews/views/textCommentRowSelectorView.ts |
|---|
| reviewboard/static/rb/js/reviews/views/unifiedBannerView.ts |
|---|
| reviewboard/static/rb/js/ui/views/dndUploaderView.ts |
|---|
| reviewboard/static/rb/js/ui/views/fieldStateLabelView.ts |
|---|
| reviewboard/static/rb/js/ui/views/floatingBannerView.ts |
|---|
| reviewboard/static/rb/js/ui/views/inlineEditorView.ts |
|---|
| reviewboard/static/rb/js/ui/views/menuButtonView.ts |
|---|
| reviewboard/static/rb/js/ui/views/menuView.ts |
|---|
| reviewboard/static/rb/js/ui/views/slideshowView.ts |
|---|
| reviewboard/static/rb/js/ui/views/textEditorView.ts |
|---|