Summary

Convert RB.HeaderView to TypeScript/spina.

Review Request #14061 — Created July 29, 2024 and submitted Aug. 8, 2024, 9:28 a.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change converts our HeaderView to TypeScript. This also fixes a
couple lost-standing annoying issues with our unit tests where some of
the page views being tested were inadvertently connecting to the page's
global HeaderView and then removing it when the test was complete. There
was also one admin-specific style that was leaking into the test page's
display of the header, so I've changed that to be specific to admin
pages.

Testing Done

Commits

Summary	ID
Convert RB.HeaderView to TypeScript/spina. This change converts our HeaderView to TypeScript. This also fixes a couple lost-standing annoying issues with our unit tests where some of the page views being tested were inadvertently connecting to the page's global HeaderView and then removing it when the test was complete. There was also one admin-specific style that was leaking into the test page's display of the header, so I've changed that to be specific to admin pages.	6cf47dac843a4fc9eae9369bbe4d41a198c0c707

Summary

Convert RB.HeaderView to TypeScript/spina.

This change converts our HeaderView to TypeScript. This also fixes a couple lost-standing annoying issues with our unit tests where some of the page views being tested were inadvertently connecting to the page's global HeaderView and then removing it when the test was complete. There was also one admin-specific style that was leaking into the test page's display of the header, so I've changed that to be specific to admin pages.

6cf47dac843a4fc9eae9369bbe4d41a198c0c707

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (87bd944)