Summary

Convert RB.FormView to TypeScript/spina

Review Request #14058 — Created July 26, 2024 and submitted Aug. 8, 2024, 9:28 a.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change ports the FormView class to TypeScript.

Testing Done


Ran js-tests.
Checked that the repository form and subforms still worked as

  expected.

Commits

Summary	ID
Convert RB.FormView to TypeScript/spina This change ports the FormView class to TypeScript. Testing Done: - Ran js-tests. - Checked that the repository form and subforms still worked as expected.	f156cc5abe196d21a595360b151bcdfaaaa5b4f2

Issues

Description	From	Last Updated
I don't know whether anyone else is using it, but moving it out of common constitutes an API breakage.	chipx86	July 29, 2024, 6:49 p.m.

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues

I don't know whether anyone else is using it, but moving it out of common constitutes an API breakage.

david July 27, 2024, 9:15 a.m.

This is all pretty specific to the way our admin forms work.

chipx86 July 29, 2024, 4:32 p.m.

Admin, very possibly Team Admin now or later, and I'd like to be able to use subforms in My Account since we have the legacy implementation-specific variants for this for things like avatars. I think this should remain in common for now.

I'd eventually like Ink to provide those form semantics, at which point we can look into deprecating some of this.

Change Summary:

Move back to common bundle.

Description:

~		This change ports the FormView class to TypeScript. This was part of the
	~	This change ports the FormView class to TypeScript.
-		common bundle, but it's only used for the admin site, so I've moved it
-		into our admin bundle instead.

Commits:

	Summary	ID
	Convert RB.FormView to TypeScript/spina This change ports the FormView class to TypeScript. Testing Done: Ran js-tests.	960400d63d6ad9fe8d9b10302ec06f5c85b52aea
	Convert RB.FormView to TypeScript/spina This change ports the FormView class to TypeScript. Testing Done: - Ran js-tests. - Checked that the repository form and subforms still worked as expected.	f156cc5abe196d21a595360b151bcdfaaaa5b4f2

Diff:

Revision 2 (+208 -118)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/common/index.ts
	reviewboard/static/rb/js/ui/views/formView.es6.js
	reviewboard/static/rb/js/ui/views/tests/formViewTests.es6.js
	reviewboard/static/rb/js/common/views/tests/index.ts

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (1f01dfb)