Summary

Prevent admins from editing fields when there's an un-viewed draft.

Review Request #14037 — Created July 13, 2024 and submitted Aug. 6, 2024, 4:50 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Testing Done


Attempted to edit review request fields, file attachment

  captions/state, and add new attachments/diffs as an admin while

  viewing a review request with an unpublished draft, but not viewing

  the draft. Saw the expected prompt.
Edited review request fields, file attachment captions/state, and

  added new attachments/diffs as both the owner and an admin while

  viewing the current draft.

Commits

Summary	ID
Prevent admins from editing fields when there's an un-viewed draft. Now that admins can make a choice about whether they want to view an unpublished draft or not, we need to be more careful about when they make edits. This change makes it so if the admin attempts to make a change to the review request when a user draft exists, we'll block the edit and prompt them to load the draft first. Testing Done: - Attempted to edit review request fields, file attachment captions/state, and add new attachments/diffs as an admin while viewing a review request with an unpublished draft, but not viewing the draft. Saw the expected prompt. - Edited review request fields, file attachment captions/state, and added new attachments/diffs as both the owner and an admin while viewing the current draft.	8509c9d396f82378c4700605595a24dc19c39b1d

Summary

Prevent admins from editing fields when there's an un-viewed draft.

Now that admins can make a choice about whether they want to view an unpublished draft or not, we need to be more careful about when they make edits. This change makes it so if the admin attempts to make a change to the review request when a user draft exists, we'll block the edit and prompt them to load the draft first. Testing Done: - Attempted to edit review request fields, file attachment captions/state, and add new attachments/diffs as an admin while viewing a review request with an unpublished draft, but not viewing the draft. Saw the expected prompt. - Edited review request fields, file attachment captions/state, and added new attachments/diffs as both the owner and an admin while viewing the current draft.

8509c9d396f82378c4700605595a24dc19c39b1d

Issues

Description	From	Last Updated
We should add a Version Added here too.	chipx86	Aug. 5, 2024, 9:33 a.m.
Most conditionals are this combination of checks. I wonder if we should just have a function that covers it?	chipx86	Aug. 5, 2024, 10:09 a.m.
Looks like this should be deleted.	maubin	July 22, 2024, 9:20 a.m.
Missing a Version Added.	chipx86	Aug. 6, 2024, 4:49 p.m.

flake8 passed.

JSHint passed.

Ship it!

reviewboard/static/rb/js/reviews/views/reviewRequestFieldViews.ts (Diff revision 1)

The issue has been resolved. Show all issues

Looks like this should be deleted.

reviewboard/static/rb/js/reviews/views/fileAttachmentThumbnailView.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
We should add a Version Added here too.
```
reviewboard/static/rb/js/reviews/views/reviewRequestFieldViews.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Most conditionals are this combination of checks. I wonder if we should just have a function that covers it?
```

Commits:

	Summary	ID
	Prevent admins from editing fields when there's an un-viewed draft. Now that admins can make a choice about whether they want to view an unpublished draft or not, we need to be more careful about when they make edits. This change makes it so if the admin attempts to make a change to the review request when a user draft exists, we'll block the edit and prompt them to load the draft first. Testing Done: - Attempted to edit review request fields, file attachment captions/state, and add new attachments/diffs as an admin while viewing a review request with an unpublished draft, but not viewing the draft. Saw the expected prompt. - Edited review request fields, file attachment captions/state, and added new attachments/diffs as both the owner and an admin while viewing the current draft.	9d7f46ccb9baed2865d733cf6ff189b0a04a9795
	Prevent admins from editing fields when there's an un-viewed draft. Now that admins can make a choice about whether they want to view an unpublished draft or not, we need to be more careful about when they make edits. This change makes it so if the admin attempts to make a change to the review request when a user draft exists, we'll block the edit and prompt them to load the draft first. Testing Done: - Attempted to edit review request fields, file attachment captions/state, and add new attachments/diffs as an admin while viewing a review request with an unpublished draft, but not viewing the draft. Saw the expected prompt. - Edited review request fields, file attachment captions/state, and added new attachments/diffs as both the owner and an admin while viewing the current draft.	8509c9d396f82378c4700605595a24dc19c39b1d

Diff:

Revision 2 (+366 -62)

Show changes

	reviewboard/static/rb/js/reviews/models/reviewRequestEditorModel.ts
	reviewboard/static/rb/js/reviews/models/unifiedBannerModel.ts
	reviewboard/static/rb/js/reviews/views/fileAttachmentThumbnailView.ts
	reviewboard/static/rb/js/reviews/views/reviewRequestActions.ts
	reviewboard/static/rb/js/reviews/views/reviewRequestEditorView.ts
	reviewboard/static/rb/js/reviews/views/reviewRequestFieldViews.ts
	reviewboard/static/rb/js/reviews/views/tests/fileAttachmentThumbnailViewTests.ts
	reviewboard/static/rb/js/ui/views/inlineEditorView.ts

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

reviewboard/static/rb/js/reviews/models/reviewRequestEditorModel.ts (Diff revision 2)
The issue has been resolved. Show all issues
```
Missing a Version Added.
```

Status:: Completed
Change Summary:: Pushed to release-7.x (c5eefb7)