Add typing for Repository, Tool, and the managers.

 






 

 


  Review Request #14032
  —
  Created July 12, 2024 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  Review Board
 









 
 

  release-7.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Repository is one of the main models used in Review Board, and until

now, we lacked any typing for the functions.


This change adds typing for Repository, RepositoryManager, Tool,

and ToolManager. It should ensure we don't pass incorrect parameters

to anything in these classes.

 








  


 
 

  
Unit tests pass.

 







 









 





  








 




 







   

    
    
Changes between revision 1 and 2



    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Add typing for Repository, Tool, and the managers.
     
`Repository` is one of the main models used in Review Board, and until
now, we lacked any typing for the functions.

This change adds typing for `Repository`, `RepositoryManager`, `Tool`,
and `ToolManager`. It should ensure we don't pass incorrect parameters
to anything in these classes.

    

   
  		
  6c8582f8e5d033426fefa2ba105bfc3f7daed3ea
  Christian Hammond
 


 
  
 
 
  
   
    

     Add typing for Repository, Tool, and the managers.
     
`Repository` is one of the main models used in Review Board, and until
now, we lacked any typing for the functions.

This change adds typing for `Repository`, `RepositoryManager`, `Tool`,
and `ToolManager`. It should ensure we don't pass incorrect parameters
to anything in these classes.

    

   
  		
  80d4de5e87f12f2ed9c6970c20c0bddf8a7082b8
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/scmtools/managers.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...